Metamask-extension: Extension, UI Bug in Send/Advanced option
Sending Dai, Click Max
In Advanced option, it shows sending ETH (in max) instead of Dai
zhangzhongnan928
All 6 comments
Thanks MetaMask/metamask-extension
On Mon, 2 Mar 2020 at 06:33, Victor Zhang notifications@github.com wrote:
Sending Dai, Click Max
[image: Screen Shot 2020-03-02 at 2 25 06 pm]
https://user-images.githubusercontent.com/33795543/75643176-43c22900-5c92-11ea-8d1a-a61b11bd0c42.pngIn Advanced option, it shows sending ETH (in max) instead of Dai
[image: Screen Shot 2020-03-02 at 2 25 20 pm]
https://user-images.githubusercontent.com/33795543/75643201-5b011680-5c92-11ea-926a-82cbfd21a78d.png—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/MetaMask/metamask-extension/issues/8150?email_source=notifications&email_token=AJEA3H63KI5GNWIEE3KZVHDRFMSGXA5CNFSM4K7LTMM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IRR3XKQ,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJEA3H6FHFIL7QLEJYCZ4D3RFMSGXANCNFSM4K7LTMMQ
.>
FredBuluku
fredbuluku
on 2 Mar 2020
@zhangzhongnan928 can you reliably reproduce this still? If so could you let me know if there are reproduction steps missing from the original issue? I am not able to reproduce to diagnose the issue.
brad-decker
on 26 Mar 2020
Should be fixed in version v7.7.8 from this PR #8176, let us know if this any other issues arise in a new issue.
tmashuang
on 26 Mar 2020
It is fixed, but
- Should the "Send Amount" show as 0 ETH or 58616.680 aUSDC
- Once change and save the gas price in "Advanced Options", The "Advanced Options button" will disappear.
zhangzhongnan928
on 26 Mar 2020
@zhangzhongnan928 i think this should be a separate issue, if you don't mind.
brad-decker
on 27 Mar 2020
Correct, it does say that the Send Amount is 0 ETH, since it is hard coded to be in that value. We would have to revisit the drawing board in how we should display this value since it is dealing with tokens. This would mean also a change in the New Total and the fiat value underneath as well. I'll open up a new issue to get the discussion open.
tmashuang
on 27 Mar 2020
Related issues
dpazdan
·
3Comments
bdresser
·
3Comments
johnerfx
·
4Comments
BassBauman
·
3Comments
whyrusleeping
·
3Comments
Most helpful comment
Correct, it does say that the Send Amount is 0 ETH, since it is hard coded to be in that value. We would have to revisit the drawing board in how we should display this value since it is dealing with tokens. This would mean also a change in the New Total and the fiat value underneath as well. I'll open up a new issue to get the discussion open.