Metamask-extension: Metamask stops working if gas is passed as an object

[rstormsf]

To Reproduce
Steps to reproduce the behavior:

1. Open https://codepen.io/rstormsf/pen/qzBRBe?editors=1010
2. Click Click me button

window.ethereum.sendAsync({
                    method: 'eth_sendTransaction',
                    params: [{
                        from: acc,
                        to: "0x0039f22efb07a647557c7c5d17854cfd6d489ef3",
                        gas: {}, // provide Gas as an Object
                        gasPrice: "0x77359400",
                        value: "0x0",
                        data: "0x0"
                    }],
                    jsonrpc: '2.0'
                }, (err, response) => {
                    window.alert(JSON.stringify(err))
                    console.log(response)
                })

Expected behavior
It should not break metamask

Screenshots

Browser details (please complete the following information):

• OS: OSX
• Browser chrome
• MetaMask Version 6.6.1

Additional context

[rstormsf]

I can't even reset the account in metamask, I can't use that account anymore. It's showstopper issue

[akshitkrnagpal]

Hi
I am new to MetaMask project and would like to work on this.
I already have a local build of MetaMask extension and I am able to reproduce the bug.

After some investigation, I found that this problem is arising because the transaction is being added in the unapprovedTxs without validation of txParams. Validation of txParams in only done in TransactionStateManager.updateTx() and not in TransactionStateManager.addTx().