Metamask-extension: Incorrect (huge) balance running on RPC 127.0.0.1:8545, mainnet

[evertonfraga]

Describe the bug
I am fully synced on Geth light mode, mainnet, connecting via RPC, though my ETH balance is far from what it was supposed to be.

./geth --syncmode light --cache 2048 --rpc --rpccorsdomain moz-extension://e582a415-cf54-468e-9b4b-f32b576f7bf7,chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn

To Reproduce
Steps to reproduce the behavior:

1. start geth 1.8.27 with the aforementioned command
2. Have it synced
3. Have the account balance updated (generally open the expanded view and/or wait a little while)
4. geth attach
5. eth.getBalance('[MY_ADDRESS]') gives me accurate balance
6. Reset the account
7. Same huge ETH balance

Expected behavior
Correct balances shown.

Screenshots

Browser details (please complete the following information):

• OS: OS X
• Browser: Chrome
• MetaMask Version: 6.4.1

Additional context
Add any other context about the problem here.

[ryanio]

I am getting the same behavior, my mainnet balance is 0.1915 ETH but it is showing 23570985008687907853269984665631340667420.7292 ETH via the Localhost:8545 network option with geth running with the above flags

[evertonfraga]

I tested the same RPC method in Postman and MyEtherWallet CX, and values are correct.

[evertonfraga]

Also happening in local RPC with Rinkeby

Using the console, I can see a bunch of RPC errors, will try to pinpoint the issue from here:

[evertonfraga]

My hunch is that metamask fails to handle this kind of response from Light Client, when it does not have the immediate answer:

{
    "jsonrpc": "2.0",
    "id": 1,
    "error": {
        "code": -32000,
        "message": "no suitable peers available"
    }
}

[danfinlay]

My hunch is that metamask fails to handle this kind of response from Light Client, when it does not have the immediate answer

Thanks for including the error message, this will help us greatly to investigate/fix.

[tmashuang]

Unfortunately, I was unable to get the issue outcome of large value, but I didn't get the no suitable peers available. Will try attempts to get this error message, might have to constantly remove my database and retry. Curious if you have every set up a private ethereum chain with your address and pre-allocate Ether to your account then swapped back to the main network?

[tmashuang]

Possible related to https://github.com/ethereum/mist/issues/3393

[evertonfraga]

Hi @tmashuang, do you have any test suite (or strategy) to mock RPC methods?

[tmashuang]

Since we primarily use Infura's API, I think we use https://github.com/nock/nock to mock those calls.

[evertonfraga]

How to (hopefully deterministically) get the no suitable peers error:

Start geth light client with the --nodiscovery flag. It'll have no means to fetch account balances.

geth --syncmode light --cache 2048 --rpc --rpccorsdomain='*' --rpcapi "db,eth,net,web3" --vmodule="rpc/*=5" --nodiscover

{
    "jsonrpc":"2.0",
    "method":"eth_getBalance",
    "params":[
        "0xADDRESS", 
        "latest"
    ],
    "id":1
}

[evertonfraga]

Curious if you have every set up a private ethereum chain with your address and pre-allocate Ether to your account then swapped back to the main network?

no, I haven't

[tmashuang]

I am getting the error,no suitable peers, now with --nodiscover. Still unable to get a large balance. I don't want to ask to removedb and resync, but I don't see where this bad balance could be coming from.

[evertonfraga]

I just produced a local build of MM 6.4.1 (version tested in the first place) and I got the huge balance:

I don't know what changes were made up to 6.5.3, and I tend to believe it might have been fixed. Can you take a spin on 6.4.1 just as sanity check?

[tmashuang]

No large balance for me on v6.4.1.

[evertonfraga]

It does not even happen with all accounts, as shown:

so I guess this is either a super difficult issue to reproduce or it's gone for good. We can close it for now and should we run into that issue again, I'll revive it.

Thanks @tmashuang

[tmashuang]

Oh wait this is an imported account? Where was this account created from?

[evertonfraga]

json file, created from geth

[tmashuang]

Ok I got it now from the account created in Geth, will investigate the root cause.

[evertonfraga]

Friendly bump @tmashuang. any conclusion? LMK if you need any help from our side.

[tmashuang]

@evertonfraga We are currently investigating this issue, and have theories and potential fixes. Would you be willing to submit your state logs to [email protected] with this issue number? Or rather continue on this thread with specific Q/As?

[evertonfraga]

Hi @tmashuang, I'd rather continue on this thread. please send your Qs :)

[rrodriguezreche]

Dropping by just to say that this still happens. I 've tried to use a custom RPC pointing to my local geth light node and I am receiving distorted values on my ETH balance. Other assets (ie tokens) are correctly displayed.

I can see the correct value when connecting to DApps like zapper.fi, but have not checked if they are getting it through their backend or through web3 calls.

[danfinlay]

If you open the background devtools (guide here), you should be able to see the network requests that fetch the balance. This could allow you to confirm that MetaMask is receiving the correct value and the fault is with us. If so, you could also copy the request & its response here for us to look at, to see if maybe something about the payload causes a wrong interpretation.