Metamask-extension: vendor folder missing

[wighawag]

Context:
building metamask from source on windows 10 (64bit)

Describe the bug
when running gulp build after a successful npm install using sha3 2.0.0 (see #6042)
I get the following error:

fs.js:115
    throw err;
    ^

Error: ENOENT: no such file or directory, scandir 'C:\dev\projects\wighawag\metamask-extension\node_modules\gulp-sass\node_modules\node-sass\vendor'
    at Object.readdirSync (fs.js:786:3)
    at Object.getInstalledBinaries (C:\dev\projects\wighawag\metamask-extension\node_modules\gulp-sass\node_modules\node-sass\lib\extensions.js:129:13)
    at foundBinariesList (C:\dev\projects\wighawag\metamask-extension\node_modules\gulp-sass\node_modules\node-sass\lib\errors.js:20:15)
    at foundBinaries (C:\dev\projects\wighawag\metamask-extension\node_modules\gulp-sass\node_modules\node-sass\lib\errors.js:15:5)
    at Object.module.exports.missingBinary (C:\dev\projects\wighawag\metamask-extension\node_modules\gulp-sass\node_modules\node-sass\lib\errors.js:45:5)
    at module.exports (C:\dev\projects\wighawag\metamask-extension\node_modules\gulp-sass\node_modules\node-sass\lib\binding.js:15:30)
    at Object.<anonymous> (C:\dev\projects\wighawag\metamask-extension\node_modules\gulp-sass\node_modules\node-sass\lib\index.js:14:35)
    at Module._compile (internal/modules/cjs/loader.js:689:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
    at Module.load (internal/modules/cjs/loader.js:599:32)

To Reproduce
Steps to reproduce the behavior:

1. npm install [email protected]
2. npm install
3. gulp build

[ArvsIndrarys]

I get the same problem with Ubuntu 16.04 :/

[ArvsIndrarys]

I got it resolved with the npm rebuild node-sass command line.

[whymarrh]

@wighawag any luck with @ArvsIndrarys' suggestion? Also, why is the extra install of sha3 required?

[ArvsIndrarys]

The installation of sha3 prevents a npm install failure because a make command that invokes node-gyp.
Cloning the project and trying npm i directly should give you the error.

[whymarrh]

Cloning the project and trying npm i directly should give you the error.

Unfortunately I can't reproduce this. This might be a Windows-related issue?

[wighawag]

Thanks @ArvsIndrarys your solution made gulp build succeed
@whymarrh for the sha3 issue it might indeed be a windows only issue, see #6042
I used version 2 to fix it but there might be a fix at a lower version that might be more suited

[ArvsIndrarys]

I got the same problem on Ubuntu 16.04 :/

[whymarrh]

@ArvsIndrarys can you share the reproduction steps for Ubuntu?

[ArvsIndrarys]

I got it by cloning the project and calling npm install. I may be an exception

[whymarrh]

@ArvsIndrarys unfortunately we can't help without the ability to reproduce this reliably. If you are unable to setup the project on Ubuntu 16.04 after following the steps outlined in the readme and have specific things we can address, please open up a new issue.

@wighawag your comment above seems like you've solved your install issue? If you're all set feel free to close this.

[wighawag]

I can close it but don't you consider it an issue that calling npm install is not enough. At least it should be documented, no?

On 7 Feb 2019 6:29 a.m., "Whymarrh Whitby" [e-mail] wrote:

@ArvsIndrarys https://github.com/ArvsIndrarys unfortunately we can't
help without the ability to reproduce this reliably. If you are unable to
setup the project on Ubuntu 16.04 after following the steps outlined in the
readme and have specific things we can address, please open up a new issue.

@wighawag https://github.com/wighawag your comment above seems like
you've solved your install issue? If you're all set feel free to close this.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MetaMask/metamask-extension/issues/6043#issuecomment-461213820,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwQNLLtfZYlP5-3wj1LqKTtJ8U6cs_tks5vK1dQgaJpZM4aGb05
.

[whymarrh]

I don't mean to seem dismissive, I would agree that if npm install didn't work it would be an issue. That said, unfortunately I can't reproduce these errors on macOS or Ubuntu (and we have devs using both to work on MetaMask). I'm not sure there's anything here that we can fix without being able to reproduce this exact error.

[wighawag]

you could simply document the fix but this is up to you :)

[whymarrh]

@wighawag I added a note to the README