Metamask-extension: Lost wakeup with ethereum.enable() using many browser tabs

Created on 17 Dec 2018 · 6Comments · Source: MetaMask/metamask-extension

When a dapp using ethereum.enable() is opened in two browser tabs, reloading two tabs at the same time locks one of them (the other loads successfully).

Steps to reproduce the behavior:

Prepare the following HTML file:

<html>
<body>
<script type="text/javascript">
console.log('init');
ethereum.enable().then(() => console.log('enabled'));
</script>
</body>
</html>

Open the HTML in two browser tabs
Refresh the tabs quickly (for me it was not even necessary to use Refresh All)
One tab logs 'init' and 'enabled', but the other one logs only 'init'

Both tabs should log 'init' and 'enabled' to the console.

Note that I had granted the permission for MetaMask to inject ethereum account for the location, so no popup appeared during the bug reproduction.
To reproduce, the HTML file location must be http://, file:// does not work.

Software versions:

Fedora release 29 (Linux 4.19.6)
Chromium 70.0.3538.110
MetaMask 5.2.2

Source

kkostalkowicz

👍3

All 6 comments

There are more cases of such behavior:
1) In development reloading of page in a background tab, triggered by recompiling source code also locks that page
2) When you reopen chrome browser it restores closed tabs. Metamask enabled page remains locked

pr0fedt on 18 Dec 2018

👍1

+1!

Veniamin on 18 Dec 2018

👍1

the same issue is on my side guys

wwwebdiller on 19 Dec 2018

👍1

I have same issue!

spigell on 21 Dec 2018

👍1

Thanks for filing this @kkostalkowicz. We're investigating this issue now and hope to include a fix as part of the next release.

bitpshr on 26 Dec 2018

👍1

There is a workaround using an event listener.

Before you need any web3:

document.addEventListener('visibilitychange', this.enable, false)

Enable call:

enable = () => {
  if(document.hidden) return;

  window.ethereum.enable()
    .then((address) => { /* Your setup with enabled web3 */ })
    .finally(() => {
      document.removeEventListener('visibilitychange', this.enable, false)
    });
}