Metamask-extension: Update ENS resolving implementation to match what is defined in EIP-1577

Created on 13 Nov 2018 · 16Comments · Source: MetaMask/metamask-extension

What problem are you trying to solve?

Name resolution is done using the content and multihash fields right now, to try and find a better system @arachnid and I created EIP-1577 that allows for a better representation of network and content addresses.

Describe the solution you'd like

Implement resolution using the new multiaddr field when available.

L20-ENS T01-enhancement bounty worthy

Source

decanus

👍2

Most helpful comment

ping @danfinlay @kumavis @decanus @Arachnid work done ✔️
review requested here

pldespaigne on 4 May 2019

🎉2

All 16 comments

There will be changes made to the EIP so implementation should be paused.

decanus on 14 Nov 2018

👍1

The EIP has been updated and should be good to go: https://eips.ethereum.org/EIPS/eip-1577

decanus on 19 Nov 2018

Pinging @PhyrexTsai in case he has bandwidth for this.

danfinlay on 19 Nov 2018

@danfinlay @bitpshr probably best to put this on pause, as we expect to update the spec again soon.

decanus on 21 Dec 2018

👍1

@danfinlay The EIP has been updated, work should be able to start on it now. https://eips.ethereum.org/EIPS/eip-1577

decanus on 10 Jan 2019

👍2

Cant connect blank screen at least 8hrs of nothing but blank

Platinumwrist on 11 Jan 2019

@Platinumwrist could you share your UI and background logs on issue https://github.com/MetaMask/metamask-extension/issues/4894 to help us debug. This issue is for something entirely different.

Instructions how to find those logs are here.

bdresser on 11 Jan 2019

Hi ! I have wirtten a small JS lib to implement EIP1577 ! @decanus and the ENS team have used it for the ENS Manager dApp (issue), so I think it could also help in Metamask :)
Also it would be an honnor for me to contribute !

pldespaigne on 11 Mar 2019

👍2

@pldespaigne that's fantastic! We would be incredibly grateful for the contribution, we want our ENS support to reflect the latest standard. Please let us know if you have any questions!

danfinlay on 13 Mar 2019

OK I will be working on it :grinning: ! Can you help me to find my way through the metamask codebase ?

pldespaigne on 13 Mar 2019

I believe our current implementation is in this folder:
https://github.com/MetaMask/metamask-extension/tree/develop/app/scripts/lib/ens-ipfs

I was just made aware of this library, which may be useful for allowing us to resolve a variety of decentralized name services, although I need to look into it more (can it use our user's configured blockchain provider?)
https://github.com/unstoppabledomains/namicorn

danfinlay on 27 Mar 2019

namicorn looks okay, but I'm not sure of its value: The format of its returned data seems to depend on the provider, and it doesn't attempt to encode or decode the content hash data at all. I'm not sure it would save you any time over just using our libraries (or calling the contracts) directly.