Metamask-extension: eth_signTypedData(): callback function is no longer called in v 4.9.0 on 'SIGN' button

Created on 8 Aug 2018  路  7Comments  路  Source: MetaMask/metamask-extension

The following code worked fine in <=v 4.8.0:

web3.currentProvider.sendAsync( {
            'eth_signTypedData',
            params,
            address
        }, 
        (err, result) => {
            // callback code
        }
);

But it stopped working in version 4.9.0.
_(err, result) => {}_
callback function is not called anymore after confirming Signature Request (SIGN button)

However, the callback function is still called on 'CANCEL' button as before.

P1-asap T00-bug

Most helpful comment

+1
BTW, when will the current eth_signTypedData be deprecated and replaced by the merged EIP-712 behaviour?

All 7 comments

+1

+1
BTW, when will the current eth_signTypedData be deprecated and replaced by the merged EIP-712 behaviour?

+1 can confirm.

I can confirm this too ...
When user clicks cancel - callback is called with first parameter null and second one contains this object:

{ 
  "error": {
    "code": -32603, 
    "message": "Error: MetaMask Message Signature: User denied message signature."
  },
  "id": undefined,
  "jsonrpc": undefined
}

But when user clicks "Sign" - nothing happens - callback doesn't trigger
It works in 4.8.0, but stops working in 4.9.0

image
Problem should be related to "Cannot read property 'EIP712Domain' of undefined
and for some reason the react is not a production build

Hi @Maxxi. This was caused by a premature version bump of a few of our dependencies and will be fixed by #4982. We plan to do a patch release shortly thereafter. Thanks for the issue report and for your patience!

Hi @bitpshr . Thanks for your quick reaction on that problem.

Was this page helpful?
0 / 5 - 0 ratings