Metamask-extension: New confirm screen: add fallback when no function is found

Created on 12 Jul 2018  路  5Comments  路  Source: MetaMask/metamask-extension

From our conversation this afternoon: if a contract isn't found and we can't look up the function call, the confirm screen shows a blank in the Parameters field and defaults to the CONFIRM header. Probably makes sense to have a fallback screen for when we don't actually know what type of function it is.

@alextsg @danjm

L03-UI

Most helpful comment

@cjeria after talking through with @alextsg, when we can't find the function we'll update the header (where it says CONFIRM) to say UNKNOWN FUNCTION and then down below on the data tab, we'll have FUNCTION TYPE: Not Found

sound good?

All 5 comments

screen shot 2018-07-12 at 3 46 44 pm

@cjeria after talking through with @alextsg, when we can't find the function we'll update the header (where it says CONFIRM) to say UNKNOWN FUNCTION and then down below on the data tab, we'll have FUNCTION TYPE: Not Found

sound good?

sounds good! @bdresser

a bit off topic, but what's up with the bright aqua blue bg color of the network?

@cjeria That's my bad. Will fix it soon.

Was this page helpful?
0 / 5 - 0 ratings