Metamask-extension: ENS Subdomain Eager Resolve
Metamask is a little to eager in trying to resolve my ENS subdomain! It works great when I copy and paste the ens name in, but doesn't do too well when I type it!
- Expected Behavior : Resolved ENS Subdomain after I finish typing it in.
- Actual Behavior: Eager resolve before I have finished
- Browser Used: Chrome
- Operating System : MacOS High Sierra 10.13.3
BKDaugherty
All 5 comments
I agree, we could save the validation for either:
- on submit
- once the string ens with a tld (should have a period between two non-zero length strings)
danfinlay
on 20 Jun 2018
once the string ens with a tld (should have a period between two non-zero length strings)
We already do this. So perhaps we just need to increase the delay on the debounce.
danjm
on 25 Jun 2018
It seems to work properly in the old UI
briansoule
on 4 Aug 2018
Could you just leave it as the name? Replacing it with the address in the input field isn't ideal.
Arachnid
on 4 Aug 2018
the resolution should be verified after the user is done entering the .eth or any other TLD (since now ens supports .xyz and will soon support more)
also agree with Nick that the name should stay visible
and as I wrote here https://github.com/MetaMask/metamask-extension/issues/4616#issuecomment-422763803
.... probably ALSO display a greyed out and shorthand version of the address
lyricalpolymath
on 19 Sep 2018
Related issues
johnerfx
路
4Comments
glitch003
路
3Comments
BMillman19
路
3Comments
DISC30
路
3Comments
1blockologist
路
3Comments
Most helpful comment
Could you just leave it as the name? Replacing it with the address in the input field isn't ideal.