Metamask-extension: Lockups up on Shopify's login page in Firefox

[corbinu]

At first I thought this was a Firefox bug but disabling each extension caused me to realize it is in metamask.

I am running 59.0b13 (64-bit) on a MacBook Pro (Retina, 15-inch, Mid 2015) with MacOS 10.13.3

I develop a Shopify app and anytime I try to login to a Shopify stores admin panel. Firefox locks up and spins the CPU all the way up. I then have to force quit.

To replicate go to any Shopify store and add "/admin" to the domain.

[kumavis]

@corbinu do you see this happening on chrome?

[corbinu]

no idea don't use chrome sorry

[scsaba]

@kumavis I managed to reproduce it in firefox, but not in chrome.

[bakaoh]

i guess the problem come from https://cdn.shopify.com/s/javascripts/tricorder/xtld-read-only-frame.html
it returns different on chrome and firefox

[vyomshm]

I'm running a MacBook Air (13-inch, 2017) with macOS 10.13.3 and i couldn't reproduce the issue, tried it with this shopify-login url. Working okay with both chrome and firefox.

[gitcoinbot]

@dnzdlklc are you still working on this issue?

[gitcoinbot]

@dnzdlklc are you still working on this issue?

[gitcoinbot]

@dnzdlklc are you still working on this issue?

• [x] warning 1 (3 days)
• [x] warning 2 (6 days)
• [ ] auto removal (10 days)

[vs77bb]

I returned this to an open status on Gitcoin due to inactivity. Because Gitcoin Bot didn't have an initial comment here, it's worth 0.3 ETH on Gitcoin as shown here!

[kylewu]

I tried with the link provided by @vyomshm . It seems my chrome has the same problem
MacBook Pro (Retina, 13-inch, Early 2015) 10.13.4
Chrome Version 66.0.3359.139 (Official Build) (64-bit)
Metamask 4.6.0

as @bakaoh mentioned, seems a problem with xtld-read-only-frame.html and metamask
is it necessary for metamask to inject js code into all frames?

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

1. @prettymuchbryce

   has committed to working on this project to be completed 10 months, 4 weeks from now.

@vs77bb, __please see the below comments / questions regarding approach for this ticket from the bounty hunter(s):__

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 0.3 ETH (201.38 USD @ $671.25/ETH) has been submitted by__:

1. 
   
   
   
   1. @prettymuchbryce
   
   

@vs77bb please take a look at the submitted work:

• PR by @prettymuchbryce

• Learn more on the Gitcoin Issue Details page
• 
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
    
    $7,813.94 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[vs77bb]

@danfinlay @kumavis Mind taking a look at @prettymuchbryce's PR when you get the chance? Hope all is well!

[prettymuchbryce]

Hello. I have submitted a fix for this issue as well as some more detailed analysis of what exactly is causing the problem in the PR. It took a little digging into the internals of metamask, and minified shopify scripts, but not too bad. I look forward to fewer crashing browsers now. 😄

[kumavis]

@vs77bb @prettymuchbryce's solution was merged

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 0.3 ETH (213.21 USD @ $710.69/ETH) attached to this issue has been approved & issued to @prettymuchbryce.__

• Learn more at on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $9,240.37 more funded OSS Work available on the Gitcoin Issue Explorer

[danfinlay]

Closing since this was merged, will be fixed in the next release.