Metamask-extension: Document minimum supported browser versions

[danfinlay]

As requested by quantstamp, minimum browser versions could help inform users with minimum specs how to get MetaMask compatible.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.17 ETH (104.56 USD @ $615.06/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $14,760.84 more funded OSS Work available on the Gitcoin Issue Explorer

[vs77bb]

Hi @danfinlay - mind checking in with @iamonuwa with the details?

[danfinlay]

@iamonuwa: I would need the list of minimum supported browser versions and which section of the metamask to put it

Sorry there @iamonuwa, if we knew the minimum supported versions, we wouldn't have posted this task.

This task includes research, to figure out exactly what our minimum supported version numbers are!

This requires doing a survey of APIs that we are using, and comparing them to browser version compatibility tables, like this:
https://caniuse.com/

[iamonuwa]

@danfinlay thank you for responding, I can work with this at the moment. I'll ask questions if any.

Thank you

[bdresser]

@rafaelboyero thanks for taking this & #3505 on! please let us know if you have any questions.

[gitcoinbot]

@rafaelboyero Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[gitcoinbot]

@realphi Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[vs77bb]

Hi @realphi how are you doing here? Please let us know if you have any questions 🙂

[gitcoinbot]

@realphi Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[realphi]

Hi @vs77bb, I thought this issue is ignored. Actually I've found a js version checker and checked your extensions with it. It says it is es7 compatible.

I need more details for clarification. You're using Firefox web extensions so the minimum version for running the extension is 57 already. What else is needed in addition of minimum browser versions?
Because currently I can check for es7 compatible browser versions and the issue is done.

[gitcoinbot]

@realphi Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[bdresser]

@realphi i believe we're using Babel to compile es7 into backwards compatible javascript in older browsers.

this issue probably requires some manual testing to identify the minimum supported browser versions for chrome, opera, brave, and firefox.

@danfinlay anything to add?

[danfinlay]

Besides the JS version we compile to, the browser APIs we use are also relevant. I'm not sure the easiest way to do this or verify it. Solid verification would probably need to be part of the output.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 8 months, 1 week ago.
Please review their action plans below:

1) ajnauleau has started work.

Just created a pull request to resolve "Version 4.x no longer compiling to es5 #3505", which is in the same category of issues.

Can added functionality to support "last 2 versions" of all supported browsers, although there are currently mixed views due to "babel-preset-env" never progressing passed "es2015" functionality due to diversity of discontinued and old browsers maintained by "last 2 versions".

Popular support is veering towards:

"browsers": [
">0.25%",
"not ie 11",
"not op_mini all"
]

Which would support all browsers with a market share of above 0.25% ( http://browserl.ist/?q=%3E0.25%25%2C+not+ie+11%2C+not+op_mini+all ).

See discussion https://github.com/babel/babel/issues/7789.

Learn more on the Gitcoin Issue Details page.

[ajnauleau]

4812 Waiting for PR to be merge, then will tackle.

[vs77bb]

Thanks for the update, @ajnauleau!

[gitcoinbot]

@ajnauleau Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

• [x] warning (3 days)
• [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

[ajnauleau]

@vs77bb There are currently two school of thoughts around this:

"last 2 versions" and browsers that are >1%, not ie 11, not op_mini

The issue with the former are browsers such as internet explorer which will seize to be updated, hence holding the codebase at es2015.

The consensus of popular opinion seems to prefer the latter option, i'm thinking of moving forward with this option.

Please let me know if you have any disagreements,

Further reads:
https://jamie.build/last-2-versions

[bdresser]

@ajnauleau >1%, not ie 11, not op_mini sounds good.

Any reason to stick to >1% or could we go as far as >.25% as mentioned above?

[ajnauleau]

@bdresser - I was actually going to follow >0.25% recommended on https://jamie.build/last-2-versions, good catch though.

My PR #4812 should be merged into develop soon and I'll be able to make a PR from there and integrate this change.

[whymarrh]

+1 to @danfinlay's comment above

Besides the JS version we compile to, the browser APIs we use are also relevant. I'm not sure the easiest way to do this or verify it. Solid verification would probably need to be part of the output.

While we can add more targets to the Babel config, I think there'll need to be some indication of what else a browser needs to support other than JS APIs. I'm thinking of #4771 and the comment there about Firefox 52 not having "the listener onConnectExternal available".

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 0.17 ETH (79.93 USD @ $470.16/ETH) has been submitted by__:

1. @ajnauleau

@vs77bb please take a look at the submitted work:

• PR by @ajnauleau

---

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
  $30,489.47 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 0.17 ETH (45.18 USD @ $265.77/ETH) attached to this issue has been approved & issued to @ajnauleau.__

• Learn more on the Gitcoin Issue Details page
  
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $17,033.20 more funded OSS Work available on the Gitcoin Issue Explorer
  
  

[vs77bb]

@ajnauleau @bdresser Just paid this one out 🙂

[ghost]

@bdresser , looks like closing is fine.