Metamask-extension: "wrong response id" after migration to new 1.0 version

Created on 17 Aug 2017 · 22Comments · Source: MetaMask/metamask-extension

Hi,

i'm reporting a bug that i'm having after the migration to the new 1.0 version (related to the deprecation of web3). i've updated the dependency and migrated all the function calls to the async ones. in the end i'm continuously getting an error about wrong ids in the response, as you can see in this screenshot.
screenshot from 2017-08-16 14-05-22

it seems that the this PR introduced a remapping of ids but i don't know the motivation of implementing such mechanism but now i can't finish the migration because of this error. i'm not used to debugging chrome extensions so i didn't tried to remove that remapping in order to see if the problem would be solved.

is anyone having this issue?

L01-injection P1-asap T00-bug

Source

phra

👍1

Most helpful comment

Having similar issues call web3.eth.call()

web3.eth.call(
    {to: contractAddr, data: callData},
    walletAddress,
    function (err, data) {
        console.log(err);
        console.log(data);
    }
).then(console.log);

screen shot 2017-08-29 at 9 51 35 pm

ajcronk on 30 Aug 2017

👍5

All 22 comments

https://github.com/ethereum/web3.js/issues/940 Reported in web3 repo as well

hrishikeshio on 17 Aug 2017

yes, i already saw it. let's wait for @kumavis or someone else!

phra on 17 Aug 2017

sounds like a new validation from web3 hitting some metamask bug related to how we rewrite ids for better uniqueness guarantees

at first glance the code looks alright, but likely where the bug as reported lurks
https://github.com/MetaMask/metamask-extension/blob/master/app/scripts/lib/inpage-provider.js#L46-L62

@hrishikeshio @phra need more exact repro instructions -- just call any method with web3 1.0 ?

kumavis on 23 Aug 2017

web3.currentProvider.sendAsync({ id: 1, method: 'eth_getBalance', params: ['0x3AE39E89Dc7e736cCe53091057A45bF44B1A566c'] }, console.log)
VM295:1 MetaMask: web3 will be deprecated in the near future in favor of the ethereumProvider 
https://github.com/ethereum/mist/releases/tag/v0.9.0
get @ chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:85
(anonymous) @ VM295:1
undefined
chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:174 null {id: 1, result: "0x0"}
web3.currentProvider.sendAsync({ id: 123, method: 'eth_getBalance', params: ['0x3AE39E89Dc7e736cCe53091057A45bF44B1A566c'] }, console.log)
VM298:1 MetaMask: web3 will be deprecated in the near future in favor of the ethereumProvider 
https://github.com/ethereum/mist/releases/tag/v0.9.0
get @ chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:85
(anonymous) @ VM298:1
undefined
chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:174 null {id: 123, result: "0x0"}id: 123result: "0x0"__proto__: Object
web3.currentProvider.sendAsync([{ id: 123, method: 'eth_getBalance', params: ['0x3AE39E89Dc7e736cCe53091057A45bF44B1A566c'] }], console.log)
VM305:1 MetaMask: web3 will be deprecated in the near future in favor of the ethereumProvider 
https://github.com/ethereum/mist/releases/tag/v0.9.0
get @ chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:85
(anonymous) @ VM305:1
undefined
chrome-extension://nkbihfbeogaeaoehlefnkodbefgpgknn/scripts/inpage.js:174 null [{…}]0: {id: 123, result: "0x0"}length: 1__proto__: Array(0)

quick check in the console - ids seem to match fine
@hrishikeshio @phra how are you initializing web3?

kumavis on 23 Aug 2017

i'm initializing web3 like this:

import * as Web3 from 'web3'
class Class {
  web3Instance: any

  constructor() {
    this.web3Instance = new Web3(window['web3'].currentProvider)
}

is this wrong? @kumavis

phra on 23 Aug 2017

looks correct - will give it ago

kumavis on 23 Aug 2017

Having similar issues call web3.eth.call()

web3.eth.call(
    {to: contractAddr, data: callData},
    walletAddress,
    function (err, data) {
        console.log(err);
        console.log(data);
    }
).then(console.log);

screen shot 2017-08-29 at 9 51 35 pm

ajcronk on 30 Aug 2017

👍5

Not sure if anyone already investigated so here are my 3 cents.

https://github.com/MetaMask/metamask-extension/blob/master/app/scripts/lib/inpage-provider.js#L49

var request = eachJsonMessage(payload, (message) => {
      var newId = createRandomId()
      self.idMap[newId] = message.id
      message.id = newId // <-- HERE
      return message
})

Above line modifies payload object from:
https://github.com/ethereum/web3.js/blob/1.0.0-beta.18/packages/web3-core-requestmanager/src/index.js#L128

var payload = Jsonrpc.toPayload(data.method, data.params);
this.provider.send(payload, function (err, result) {
    if(result && result.id && payload.id !== result.id) return callback(new Error('Wrong response id "'+ result.id +'" (expected: "'+ payload.id +'") in '+ JSON.stringify(payload)));
//...

And when the id of result and payload objects is compared, payload contains randomly generated id but result has properly translated id.

From very brief investigation it looks like solution would be to duplicate payload object so that it's not modified.

var request = eachJsonMessage(payload, (message) => {
      var newId = createRandomId()
      self.idMap[newId] = message.id
      message = Object.assign({}, message); // NEW
      message.id = newId
      return message
})

For my local testing (modified inpage.js file in devtools) it worked.

gkapkowski on 3 Sep 2017

👍1

@gkapkowski thanks for your findings! hope that @kumavis can have a look soon!

phra on 4 Sep 2017

Would be really great if this got looked at. Web3 v1+ is such a better development experience with promises and async functions and its a shame we're not able to upgrade to it to work with metamask.

monokh on 6 Sep 2017

@gkapkowski thanks for digging - that makes sense - will prioritize

kumavis on 6 Sep 2017

🎉2

Unfortunately, I am receiving the async error 100% of the time as of this fix.
I am trying to call this.willContract .new({ from: this.defaultAddress, })