Metamask-extension: Infinite reload bug

Created on 18 Oct 2016  路  6Comments  路  Source: MetaMask/metamask-extension

Submitted by "joe" on our Slack.

His app, Community is experiencing an infinite refresh bug.

The console shows this error:

screen shot 2016-10-18 at 1 15 59 pm

T00-bug
Source
picture danfinlay

Most helpful comment

@ropod7
I will take another look at this

picture kumavis on 17 Dec 2016
👍2

All 6 comments

Those errors are from ipfs, I don't think they're related.

It does not always get stuck in this loop.

danfinlay picture danfinlay on 18 Oct 2016

The reload is being called by the endOfStream(PingStream, triggerReload) line.

The PingStream is timing out, so we need a more tolerant way of handling a ping timeout than reloading.

danfinlay picture danfinlay on 18 Oct 2016

The change we made to "fix" this was based on a misunderstanding -- I'm reverting that change now which may cause this issue to re-appear. See https://github.com/MetaMask/metamask-plugin/issues/873 for more info

fyi ^ @ChicoBitcoinJoe

kumavis picture kumavis on 7 Dec 2016

@ropod7
I will take another look at this

kumavis picture kumavis on 17 Dec 2016
👍2

We are calculating extension comms failure with a setTimeout -- messages seemed to be blocked, and then the timeout triggers the redirect.

I think we could use a series of smaller setTimeouts to calculate an unblocked time span

kumavis picture kumavis on 19 Dec 2016
👍1

It's fixed. Thanks!

ropod7 picture ropod7 on 21 Dec 2016
Was this page helpful?
0 / 5 - 0 ratings

Related issues

ERC1975 picture ERC1975  路  75Comments
lsankar4033 picture lsankar4033  路  61Comments
danfinlay picture danfinlay  路  98Comments
santiagorp picture santiagorp  路  54Comments
chafey picture chafey  路  79Comments