Metamask-extension: check for non-zero-balance accounts when restoring from a seed

[kumavis]

edited July 25, 2018 by @danfinlay

its confusing when the next account is not empty and not restored by default.

Example user pain:

nabob [9:54 AM]  
I got one more issue, I have created two accounts In testnet morden metamask. for some series of Testing  cases i have reinstalled chrome and metamask

[9:55]  
and used same existing vault, But, i see my second walet is missing from metamask vault

[9:55]  
How can we retrieve second wallet ?

Solution/Spec

When first restoring MetaMask from a previous seed phrase, in a loop:

• Generate an additional account
• Check if that new account has a balance
  
  
  
  • If it does, restart the loop
  
  
  • If it does not, remove that account and end the loop.
  
  

This way we immediately generate as many accounts as have ether in a row.

Should include a test to demonstrate it works.

[frankiebee]

Blocked till multi-vault integration

[danfinlay]

@frankiebee I'm marking this un-blocked, because the MultiVault branch is now stable enough that you can develop this feature on top of it.

https://github.com/MetaMask/metamask-plugin/tree/i328-MultiVault

[frankiebee]

Excellent!

[danfinlay]

This will require a hard limit of how many accounts we check for a balance, I'd propose 10 as a "almost definitely more than someone would keep empty" level.

[frankiebee]

that's what i was thinking

[frankiebee]

Blocked till main net is set to the default #1203

[danfinlay]

Raising the priority on this because our support metrics show this is a pain for a significant number of people.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__This issue now has a funding of 0.3 ETH (142.66 USD @ $475.54/ETH) attached to it.__

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $31,176.14 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work has been started__.

These users each claimed they can complete the work by 4 months, 2 weeks ago.
Please review their action plans below:

1) dmvt has been approved to start work.

I will follow the work plan outlined, iterating over generated accounts until there is no balance found. I'm not 100% on how to write the test, but will be happy to learn. If approved, I will begin work tomorrow morning.

Learn more on the Gitcoin Issue Details page.

[dmvt]

Glad to be working on this. It was a pain point for me early on as well.

[gitcoinbot]

💰 A crowdfund contribution worth 0.10000 ETH (47.25 USD @ $472.48/ETH) has been attached to this funded issue from @owocki.💰

Want to chip in also? Add your own contribution here.

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__Work for 0.3 ETH (125.01 USD @ $416.69/ETH) has been submitted by__:

1. @dmvt

@danfinlay please take a look at the submitted work:

• PR by @dmvt

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $30,039.94 more funded OSS Work available on the Gitcoin Issue Explorer

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

__The funding of 0.3 ETH (88.49 USD @ $294.96/ETH) (plus a crowdfund of 0.1 ETH worth $47.5) attached to this issue has been approved & issued to @dmvt.__

Thanks to @owocki for their crowdfunded contributions to this bounty.

• Learn more on the Gitcoin Issue Details page
  
  
  
  • Questions? Checkout Gitcoin Help or the Gitcoin Slack
  
  
  • $21,538.59 more funded OSS Work available on the Gitcoin Issue Explorer