Metals: -Dvscode.workspace= should be removed

Created on 12 Dec 2017  路  8Comments  路  Source: scalameta/metals

Or it should default to the current working directory. This would make it easier to use coursier bootstrap -o metaserver since the workspace can be passed dynamically on start. Related #111

tech debt

All 8 comments

By the way, the language server communicates the workspace path at initialization. The only usage of the workspace directory before the server has started is for logging, but we can easily work around that. I think we should remove the workspace parameter entirely.

I see, cool, then we should default to working directory .metaserver/*. We should keep the compilerconfig files there too IMO. Question if we should rename metaserver to something better before doing this?

I think that's ok keeping the name for now. I don't think it will be such a breaking change if we rename it in the future.

OK, cool, are y'all ok with using .metaserver/*? I think target/ is quite sbt specific and doesn't play nicely with other build tools.

Sure, I think .metaserver is good enough for the time being.

Do you mean ~/.metaserver? I thinks it's ok, but I would also suggest to follow the same way as with cache directories, i.e. use XDG and other analogous conventions on each system.

I think @olafurpg means <projectWorkspace>/.metaserver, since it contains project-specific stuff such as the server logs.

That's a good idea @laughedelic we should use the directories library to follow conventions of every OS. For the logs/.compilerconfig files we store it per-workspace.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

olafurpg picture olafurpg  路  4Comments

vadeg picture vadeg  路  3Comments

laughedelic picture laughedelic  路  4Comments

laughedelic picture laughedelic  路  3Comments

romanowski picture romanowski  路  4Comments