Metadatamanagement: Improve Zofar export of MDM questions

[kpstephan]

• [ ] Try to import Zofar questions to MDM
• [ ] ... if it is not possible, give @dzhwmeisner Feedback
• [ ] Check the values of the questions for correctness

[rbirkelbach]

@rreitmann @AndyDaniel1 I think this would be a good candidate for the next sprint. question-image jsons are still not valid and contain irrelevant stuff. Not sure about question-jsons.

[AndyDaniel1]

You're completly right in stressing the importance of this topic. If you hadn't prioritised this issue with 1 I would've done it. Still I need an update on the state of zofar import topic in general.

[UteH]

@rreitmann fyi our feedback for the zofar question export of gra2005.3 https://github.com/dzhw/zofar/issues/143#issuecomment-482171084

[rreitmann]

The following list describes the reasons why we currently use https://dzhw.github.io/questionMetadataPreparation and do not directly import the zofar exprt:

• zofar does not know our conceptIds hence they are missing in the question jsons and we need to add them
• question image metadata: resolution has the wrong format, must be "resolution": { "widthX": 1200, "heightY": 800}
• question image metadata: imageType, file, questionId, dataAcquisitionProjectId should not be present cause they are filled during import by the MDM
• question metadata: id, dataAcquisitionProjectId, studyId should not be present cause they are filled during import by the MDM
• ~question metadata: questionNumber (name of the json) is not consistent with the number in the instrument pdf (see https://github.com/dzhw/zofar/issues/143#issuecomment-482171084), we correct the questionNumber in the handcrafted excel~
• ~question metadata: there are a couple of issues (see https://github.com/dzhw/zofar/issues/143#issuecomment-482171084) which might result from a problem with mapping zofars QML to our metadata fields, these fields are corrected manually by us~

[rreitmann]

@UteH Have you informed Zofar about the requirements in my previous comment?

[UteH]

@rreitmann
No. As I recall, we had agreed to just list the problems but not investigate further (yet).

I can provide the most current export for nacaps2018.2. You are welcome to review it an give me the most currenct version of _your_ requirements. I can then ask zofar about it as we will be in contact soon.

(However, I will get in touch regarding https://github.com/dzhw/metadatamanagement/issues/2606 as we discussed)

[rreitmann]

@UteH I had a quick look on the Nacaps export. I have updated my https://github.com/dzhw/metadatamanagement/issues/1412#issuecomment-511739404. The current issues are all mitigated by converting the zofar export to the handcrafted one. IMHO there will always be the need for manually correcting the zofar export (at least due to conceptIds) and therefore there is no need to fix this on the Zofar side.

[UteH]

@rreitmann thanks for the quick review. So I could ask them to omit/change the remaining attributes mentioned above (but we do not depend on it)

conceptIds will not be altered as it has to be filled by us

[rreitmann]

@UteH if they change the resolution we would need to change questionMetadataPreparation. It is a minor change but we would need to know when they change it...