Messagekit: Add support another X devices

Created on 17 Sep 2018  路  4Comments  路  Source: MessageKit/MessageKit

Hi everyone!

Look at this:
https://github.com/MessageKit/MessageKit/blob/6374b87992447e203eb313fafc3c6d56722e4f62/Sources/Controllers/MessagesViewController%2BKeyboard.swift#L96-L98

New iPhone X devices have another display height:

iPhone XR - 1792px
iPhone XS Max - 2688px

For fix, look at this: https://stackoverflow.com/a/47067296

confirmed bug
Source
picture wcoder
👍2

Most helpful comment

@nathantannar4 More device bounds logic to haunt us :trollface:

picture SD10 on 17 Sep 2018
🎉2

All 4 comments

@nathantannar4 More device bounds logic to haunt us :trollface:

SD10 picture SD10 on 17 Sep 2018
🎉2

Is this still a bug? I believe iPhoneXBottomInset was removed (in 2.0.0 ?).

austinwright picture austinwright on 22 Feb 2019

I don't think it is

Sent with GitHawk

nathantannar4 picture nathantannar4 on 22 Feb 2019
👍1

This was fixed in: https://github.com/MessageKit/MessageKit/pull/787

gwynantj picture gwynantj on 17 Feb 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Abacaxi-Nelson picture Abacaxi-Nelson  路  4Comments
mlequeux picture mlequeux  路  3Comments
adri4silva picture adri4silva  路  4Comments
ahmedwasil picture ahmedwasil  路  3Comments
TheDarkCode picture TheDarkCode  路  3Comments