Meshery: The validation for protocol in URL donst allow urls without top level domain.

[dhruv0000]

Description

The protocol wont consider http://172.17.0.2:31329/productpage as a vaild URL as it lacks a top level domain.
Rather it would accept http://172.17.0.2:31329.com/productpage
Expected Behavior

Screenshots

[kushthedude]

@dhruv0000 I guess this is an error of regex being used for URL validation, I guess this regex should work fine

export const compulsoryProtocolValidUrlPattern = new RegExp('^(https?:\\/\\/)' // compulsory protocol
  + '((([a-z\\d]([a-z\\d-]*[a-z\\d])*)\\.)+[a-z]{2,}|' // domain name
  + '((\\d{1,3}\.){3}\\d{1,3}))' // OR ip (v4) address
  + '(\\:\\d+)?(\/[-a-z\\d%_.~+]*)*' // port and path
  + '(\\?[;&a-z\\d%_.~+=-]*)?' // query string
  + '(\\#[-a-z\\d_]*)?$', 'i'); // fragment locator

[KarenEfereyan]

Hmmn. I'm trying to understand this issue

[KarenEfereyan]

@kushthedude are you saying this regular expression you just provided will work? If yes, where should it be added?

[dhruv0000]

I checked the regex. It should work. As for where the place where the regex is matched, you can find it in the MesheryPerformanceComponent @KarenEfereyan

[shubhamgupta2956]

Hello everyone. @KarenEfereyan are you working on this issue? If not, can I work on it?

[KarenEfereyan]

@shubhamgupta2956 i want to but im not sure how to. You can take it up but can i learn from you?

[shubhamgupta2956]

Yeah sure @KarenEfereyan. @kushthedude, @dhruv0000 can you please assign this issue to me?

[KarenEfereyan]

@shubhamgupta2956 it to you. Can we talk on slack? So i see how you solve it

[shubhamgupta2956]

Yeah sure. I am Shubham Gupta on slack also :slightly_smiling_face:

[dhruv0000]

Sure @shubhamgupta2956 . Ping me on slack if you both are still confused. @shubhamgupta2956 @KarenEfereyan

[KarenEfereyan]

@dhruv0000 definitely

[KarenEfereyan]

@dhruv0000 , Shubham has been so nice. We set up a zoom call and walked me through. I totally understand what was done now. I want to set up my development environment so that I can test the changes myself.

[shubhamgupta2956]

@dhruv0000 I have made a PR #1583. Please review it :slightly_smiling_face:

[dhruv0000]

Great @shubhamgupta2956 . @KarenEfereyan you can checkout the UI contribution flow to setup your environment.