Meshery: [mesheryctl]: Move hardcoded mesheryctl config defaults to a generated default mesheryctl.yaml file

Created on 29 May 2020  路  10Comments  路  Source: layer5io/meshery

Current Behavior
mesheryctl uses hardcoded defaults if the user does not specify a --mesheryctl-config file location.

Desired Behavior
It will be a better UX and more intuitive (in terms of config file syntax) if a default mesheryctl.yaml file is generated when meshery is initialized (similar to meshery.yaml) with the default values, while getting rid of the hardcoded defaults


Resources
N/A

Alternatives / Additional Context
N/A

componenmesheryctl issudesign required issuwillfix kinenhancement languaggo

Most helpful comment

Should I pick this one up @sladyn98, @nitishm and @leecalcote ??

All 10 comments

@nitishm @kushthedude can you assign this to me?

@harsh-not-haarsh fyi - here is the PR that recently brought in this functionality - https://github.com/layer5io/meshery/pull/1047

@nitishm will you double-check that a mesheryctl.yaml is autogenerated? I'm missing one in my setup.

@nitishm will you double-check that a mesheryctl.yaml is autogenerated? I'm missing one in my setup.

@leecalcote this hasn't been done yet. Currently it requires a manual creation of the file ifthe user wises to override hardcoded defaults

This could be a good step just when it is initialized. Should the YAML be populated with default values ? Also it would be nice to let the user know that we are generating such a file and you can edit it before you start. Or you can reload the yaml

@sladyn98

This could be a good step just when it is initialized. Should the YAML be populated with default values ? Also it would be nice to let the user know that we are generating such a file and you can edit it before you start. Or you can reload the yaml

I think populating it with the defaults from the constants would be ideal. If a config file is not found, there should be a command to initialize it. We must ensure that there is an option to pass the path to the config file and default to a known location.

Should I pick this one up @sladyn98, @nitishm and @leecalcote ??

This currently blocks one of my PR which Lee referenced.

This PR creates a new config file (mesheryctlConfig.yaml) based on default values and put's it into .meshery folder

Way to knock this out, @anirudhjain75! 馃挭

Was this page helpful?
0 / 5 - 0 ratings

Related issues

sakomws picture sakomws  路  4Comments

leecalcote picture leecalcote  路  3Comments

leecalcote picture leecalcote  路  4Comments

leecalcote picture leecalcote  路  4Comments

leecalcote picture leecalcote  路  4Comments