Meshery: [UI] Results: Props not retained after sorting/searching

[kushthedude]

Description

Results: Props not retained after sorting/searching
Expected Behavior

Table Props should be retained irrespective of any action performed on table.

Fix
Was bug in the dependency itself & was fixed when we jumped to 3.1.1 from 2.14

[Vineet-Sharma29]

Would like to work on it. Can you tell which files to look at?

[kushthedude]

You would want to take look at components/MesheryResults .

On Thu, 14 May, 2020, 12:22 Vineet Sharma, [e-mail] wrote:

Would like to work on it. Can you tell which files to look at?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/layer5io/meshery/issues/970#issuecomment-628427688,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLR3HB6DFBYYOBKPZDDRROIL3ANCNFSM4M2GE42A
.

[Nikhil-Ladha]

I just checked the table in the Results page, everything seems fine to me. Can you confirm the issue once @kushthedude ?

[kushthedude]

Already confirmed, can you share a GIF if its working fine on your local?

On Sun, 2 Aug, 2020, 16:21 Nikhil_Ladha, [e-mail] wrote:

I just checked the table in the Results page, everything seems fine to me.
Can you confirm the issue once @kushthedude
https://github.com/kushthedude ?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/layer5io/meshery/issues/970#issuecomment-667658425,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLRIZANJFOXKYDJVIB3R6VAK3ANCNFSM4M2GE42A
.

[Nikhil-Ladha]

This is what you were saying about, right?

[kushthedude]

Try to modify table props, show/hide columns and then try sorting or any
tabular function

On Sun, 2 Aug, 2020, 16:42 Nikhil_Ladha, [e-mail] wrote:

[image: results_page]
https://user-images.githubusercontent.com/29438875/89121724-054dc600-d4df-11ea-98ef-869e8ad84dca.gif
This is what you were saying about, right?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/layer5io/meshery/issues/970#issuecomment-667660366,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AKQMTLVMVAXVIMGCJ6NKXP3R6VCYPANCNFSM4M2GE42A
.

[Nikhil-Ladha]

Tried with that too, if you could share the issue what you are facing that would be more helpful here.

[kushthedude]

@Nikhil-Ladha the bug was in the dependency & was fixed when we made a jump of 7 major versions in dependabot over here https://github.com/layer5io/meshery/pull/1167 .

Thanks for bringing in to notice, I guess this can be closed 👍 !

[kushthedude]

One of the advantages of keeping dependencies in check 😄

[Nikhil-Ladha]

Woof! Nice 👍😆