Meshery: UI: Provide anchor on each Settings tab for deep-linking

Created on 13 Feb 2020  路  8Comments  路  Source: layer5io/meshery

All 8 comments

@leecalcote Can I take this up?

@snitin315 please, sir, yes. This "small" enhancement will have no "small" impact on user confusion when trying to nav the app.

@snitin315 Are you still working on this? Can I take this?

Feel free to work on it.

@aayushdutt an example use case should have been noted in the description. Here's one:

Current behavior:

  • A user doesn't have an Istio adapter configured.
  • They click on "Istio" in the navigation bar.
  • They see a "Configure Settings" button instead of actions to take with the adapter.
  • They click on "Configure Settings" and are dropped off at /settings, which shows them the Environment tab (wrong tab).

We want to change that last step's behavior.

Got it @leecalcote
I went through #671 and it looks like the description you gave above. I'll be working on the same next.
However, I guess the current behaviour when Istio adapter is not configured is that it does nothing when clicked on "Istio" on the navbar.

@aayushdutt, good point. I was just noticing this same behavior. I suppose what I described is only true for the first two bullets. It would be an improvement if we were to implement the two last bullets with the new anchor included.

@leecalcote That would be great.

What do you think about -

  • We put a label next to "Istio" in the navigation bar which says Not Configured (probably with a similar styling of labels as that on GitHub)
  • When it's clicked, it directly redirects to /settings page to configure it.
  • After redirecting, it shows a toast which says something like "Please configure Istio first"

image

Was this page helpful?
0 / 5 - 0 ratings

Related issues

MukulMaheshwari picture MukulMaheshwari  路  4Comments

leecalcote picture leecalcote  路  3Comments

leecalcote picture leecalcote  路  4Comments

chandrashritii picture chandrashritii  路  3Comments

leecalcote picture leecalcote  路  4Comments