mesheryctl: Make `mesheryctl init` an internal function only; Do not expose `init` as a command line operation

Created on 1 Nov 2019  路  5Comments  路  Source: layer5io/meshery

Current Behavior
Users can directly invoke mesheryctl init. This command is intended for use by other mesheryctl commands, not for use by users.

See Meshery Installation & Packaging for more information.

Desired Behavior
Hide init from user invocation.

componenmesheryctl help wanted kinenhancement

All 5 comments

Hi, Lee.

When we're going to call the init command by start and update?

We can name that function to something like: installPrereq and move it to vars.go.

We can name that function to something like: installPrereq and move it to vars.go.

@jesuslerma spot on. Yes, your suggestion is ideal.

When we're going to call the init command by start and update?

Given init's current functionality, the most appropriate time to call it is upon finding that certain prerequisites are missing (namely docker-compose at the moment). Ultimately, init (or function(s) that replace it, should include more preflight / prerequisite checks like ensuring that the user's $HOME is writeable or that the current user has permission to execute docker-compose up and so on).

@jesuslerma @anandrkskd how did we make out on this issue?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

anirudhjain75 picture anirudhjain75  路  4Comments

leecalcote picture leecalcote  路  4Comments

leecalcote picture leecalcote  路  3Comments

leecalcote picture leecalcote  路  4Comments

navendu-pottekkat picture navendu-pottekkat  路  4Comments