Mentorship-backend: Bug:Use HTTPStatus code values instead of enum representation, in mentorship_relation API in Swagger UI

[Aaishpra]

Describe the bug

The values shown on Swagger UI of mentorship_relation API should be in number format instead of Enum Representations of Status Codes. For example 200 instead of HTTPStatus.OK.

To Reproduce

Steps to reproduce the behavior:

1. Go to https://mentorship-backend-temp.herokuapp.com/
2. Scroll down to mentorship_relation
3. See enum representation.
4. 
   

Expected behavior
Use of Values of Status Codes instead of Enum Representations in Swagger UI

Desktop (please complete the following information):

• OS: Ubuntu 20+
• Browser FireFox Web Browser
• Version --

[Aaishpra]

@isabelcosta can you have a look at the issue and assign this to me?
Thanks.

[isabelcosta]

Sounds good, I will assign it to you @Aaishpra

[Aaishpra]

Sounds good, I will assign it to you @Aaishpra

Thanks, will start working on this as soon as i setup the project 😄

[isabelcosta]

To enhance your issue, I added a screenshot of how it shows up now with enum representation

[Aaishpra]

To enhance your issue, I added a screenshot of how it shows up now with enum representation

Thanks a lot 😊

[Aaishpra]

@isabelcosta @devkapilbansal @vj-codes I have some doubts, regarding how to proceed further in this issue. Since the swagger.json file was deleted by #804, I managed to find two links to find the swagger.json this and after setting up the project locally this after that I tried to save the swagger.json file (found from the link after local setup) under the docs section and editing it but nothing happens.
For example
If I edit something in mentorship_relation.py

I see a change on my local server

But nothing happens if I change anything in swagger.json

This is my first time working with Swagger, so I might be completely wrong with my approaches. Can you people help me with this?

[devkapilbansal]

@Aaishpra you should look into mentorship.py file
There you can see that it is returning HTTPStatus.Ok but it should return something like HTTPStatus.OK.value. To get better idea look into the existing PRs on hard coded status codes
Some of them are #924 #860

[Aaishpra]

@Aaishpra you should look into mentorship.py file
There you can see that it is returning HTTPStatus.Ok but it should return something like HTTPStatus.OK.value. To get better idea look into the existing PRs on hard coded status codes
Some of them are #924 #860

Ohh now i get it, so we have to make changes in mentorship_relation.py file only.
Not in the swagger.json

[devkapilbansal]

Yes, you need to make changes in UI only
Cc:- @isabelcosta

[Aaishpra]

@devkapilbansal @isabelcosta i changed all the HTTPStatus.x to HTTPStatus.x.value in mentorship_relation.py and I think this has worked correctly

Shall I submit PR if this looks right to you people?

[devkapilbansal]

@Aaishpra please open issues for other files too

[isabelcosta]

@devkapilbansal @isabelcosta i changed all the HTTPStatus.x to HTTPStatus.x.value in mentorship_relation.py and I think this has worked correctly

Shall I submit PR if this looks right to you people?

@Aaishpra it looks nice :)
if you could do what @devkapilbansal said as well, that would be great 🙌

[Aaishpra]

Sure, I will open the issues for user and admin api @devkapilbansal @isabelcosta

[Aaishpra]

@devkapilbansal @isabelcosta i changed all the HTTPStatus.x to HTTPStatus.x.value in mentorship_relation.py and I think this has worked correctly

Shall I submit PR if this looks right to you people?

@Aaishpra it looks nice :)
if you could do what @devkapilbansal said as well, that would be great raised_hands

Thanks.