Mentorship-backend: Fix: refactor HTTP error codes PUT /mentorship_relation/{request_id}/task/{task_id}/complete

[mtreacy002]

Description

As a GSoC student,
I need the correct HTTP error response code to be returned accordingly by Mentorship System API in relation to PUT /mentorship_relation/{request_id}/task/{task_id}/complete,
so that I can represent the error message accordingly to both Mentorship System and Bridge In Tech users.

Mocks

NA

Acceptance Criteria

Update [Required]

• [ ] 409: Conflict need to be returned instead of 400: Bad Request if the task was already achieved

Enhancement to Update [Optional]

NA

Definition of Done

• [ ] All of the required items are completed.
• [ ] Approval by 1 mentor.

Estimation

1 hour

[nandini45]

can i work on it?

[vj-codes]

@nandini45 Are you available to work on this?

[nandini45]

yes @vj-codes sorry for the late comment

[vj-codes]

Assigning you @nandini45
Happy coding!

[nandini45]

@vj-codes i am working on it.
need some time..a little caught with my other work

[vj-codes]

@nandini45 hows the PR going?

[nandini45]

my laptop broke down
i need time to assemble back.
you can assign it to someone else

[PrashanthPuneriya]

@divyanshugit Do you want to work on this issue? This issue gives you an overview of the project flow.

[divyanshugit]

@PrashanthPuneriya Yes, I would love to work on this issue !!

[PrashanthPuneriya]

Assigned you this issue @divyanshugit . Looking forward for your PR :)

[vj-codes]

@divyanshugit hey how's the PR going?

[divyanshugit]

@vj-codes , @PrashanthPuneriya Now the task API is changed to HTTPstatus.FORBIDDEN (in #682). Do I still need to change it to 403:FORBIDDEN to 409:CONFLICT?

[PrashanthPuneriya]

@divyanshugit To my knowledge #682 has no impact on this issue. You still need to refactor the status code to 409:Conflict. May be I am wrong. What's the reasoning behind this question?

[divyanshugit]

@PrashanthPuneriya I mean in file app/api/dao/task.py:

Do I need to change the HTTPstatus.FORBIDDEN to HTTPstatus.CONFLICT?

[PrashanthPuneriya]

Yes! You need to change every related piece of code. Since, you got this doubt I would suggest you to read this wiki to understand more about the codebase.

[vj-codes]

@PrashanthPuneriya is this an OSH issue?

[PrashanthPuneriya]

No! I don't think so @vj-codes

[vj-codes]

I would like to work on this :)

[vj-codes]

Update changes done will send a PR tomr