Mentorship-backend: Optimize query of unverified users in scheduler

[isabelcosta]

Description

The idea is to optimize query of unverified users, so that these are fetched directly from the database instead of fetching all and then filtering with python code.

In this line https://github.com/anitab-org/mentorship-backend/blob/develop/app/schedulers/delete_unverified_users_cron_job.py#L20 you can see the code fetches the all users fro UserModel and only then it filters non verified users

Acceptance Criteria

Update [Required]

• [ ] Filter unverified users from UserModel instead of from the list of users returned from it.

Definition of Done

• [ ] All of the required items are completed.
• [x] Approval by 1 mentor.

Estimation

1 hour

[PareenKarpe]

@isabelcosta If this issue is available. Can I work on it?

[isabelcosta]

@PareenKarpe yes you can :) I just assigned this to you

[PareenKarpe]

@isabelcosta I am replacing the above query with the below

unverified_users = list(
            UserModel.query.filter_by(is_email_verified=False).all()
        )

[PareenKarpe]

@isabelcosta I have committed the changes on my fork branch. But I am not sure how exactly I can test it as its a cron job. Can you help me with it? So after testing I can create a pull request for my committed changes

[isabelcosta]

@PareenKarpe your code suggestion is totally correct :D
If you wish you can already send the PR, even if in a work in progress state.

In terms of testing, I would say you can reduce the timing of the cron job for 1 min for example, and have a couple of users verified and not verified in the database (e.g.: 1 user with email verified and 2 with email not verified, after that cron job execution you should only have the first user).

How does this sound?

[PareenKarpe]

@isabelcosta Sure it sounds good. I am trying to test it. But every time I am registering a user I get 500 response and this error at the terminal
return self.digest_method(salt + b"signer" + self.secret_key).digest() TypeError: can't concat NoneType to bytes
I am missing something with this. Can you help me with it?

[isabelcosta]

@PareenKarpe have you set the environment variables? That might be the issue.
👉 https://github.com/anitab-org/mentorship-backend/blob/develop/docs/environment-variables.md

[PareenKarpe]

@isabelcosta I am doing it the same way mentioned in the link. I will check it again

[PareenKarpe]

@isabelcosta Thank a lot for helping. I was passing in the wrong format without the quotes. The query works and only deletes users who are not with verified emails. I am sending the PR request for the commit.

[isabelcosta]

Yey! 🎉 I'm so happy you managed to do this and test it properly 👏 👏 @PareenKarpe