Mentorship-backend: Refactor codebase to correct all comparisons

[ramitsawhney27]

Describe the bug
There are multiple incorrect comparisons in the code, these include:

1. Comparing booleans with 'is', 'is not', '==' and '!='
2. Comparing None with '==' or '!='
3. Comparing objects in terms of identities and not values

To Reproduce
Steps to reproduce the behavior:
-

Expected behavior
Correct comparisons everywhere
Screenshots
N/A

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
N/A

[agarwalrounak]

I will work on it

[isabelcosta]

I think this better be a first timers only issue @agarwalrounak since it's easy to do.

[LordGameleo]

I have done this part to the scripts I touched

[HSR05]

@isabelcosta I will work on it. Can you just guide me a little? Thankyou. :)

[LordGameleo]

@HSR05 this issue revolves around the use of is and == operators. Please read about it first a little at https://stackoverflow.com/questions/2209755/python-operation-vs-is-not

If you have any doubt ask here or on Slack

[isabelcosta]

@HSR05 I hope @LordGameleo answered your doubt.
Thank you for the help @LordGameleo 🎉

@HSR05 do you still want to work on this?

[LordGameleo]

@HSR05 Are you still working?

[HSR05]

@LordGameleo Currently i have exams so i am busy with those. Will look at it in few weeks. Sorry for the delay.

[LordGameleo]

No Issues :)

[LSariel]

Is this issue available? :)
I would like to find an issue to start with, so I'd love to do it if it's free.

[isabelcosta]

@LSariel yes this is taken for now. @HSR05 you're still interested in this right?

[LSariel]

Okay! Thank you. :)

[HSR05]

It's okay if @LSariel wants to make a PR, I'll be free in 3 days and will be able to work on this after that only. Really sorry for the delay.

[LSariel]

It's fine for me! :) If you want to do it, you should!

Den tors 2 maj 2019 kl 18:46 skrev HSR05 [e-mail]:

It's okay if @LSariel https://github.com/LSariel wants to make a PR,
I'll be free in 3 days and will be able to work on this after that only.
Really sorry for the delay.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/systers/mentorship-backend/issues/201#issuecomment-488746434,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGLPOGU2S7MQJRM7GW5SEVLPTMLFZANCNFSM4GZF3M2A
.

[efitzpatrick]

Is this issue available to work on right now?

[Tsukaiyo]

Can I do it?

[isabelcosta]

Unfortunately, I lost track of who was working on this.
@efitzpatrick I'm sorry I missed your message. I just saw your message now, let us know if you're still interested.

@Tsukaiyo if within 2 days there's no one showing interest for this than you can take on this issue.

[clemencetbk]

Can I work on this?

[isabelcosta]

@clemencetbk yes you can! since there aren't any updates from previous contributors.