Mentorship-android: Enhancement of the UI of the login screen

Created on 25 Aug 2020 · 18Comments · Source: anitab-org/mentorship-android

Describe the bug
Currently, when the user first opens the application, the login screen appears. The login screen has a layout in which all UI elements are present. The layout ends above the screen leaving a greyish area below it.

Expected behavior

Match parent the parent layout so that the UI looks cleaner.

Screenshots

Smartphone (please complete the following information):

Device: Realme 5
Version: Android 10
Android OS

Additional context
NA

User Interface Open Source Hack Enhancement

Source

garimasingh128

Most helpful comment

I don't think this is a design issue. This is a UI issue in which you simply have to extend the grey background present in the background so that the weird separation between white and grey backgrounds is not created. So, you can simply modify the Login Activity XML file and resolve the issue simply by making the background match parent,

garimasingh128 on 4 Sep 2020

👍2

All 18 comments

the layout containing all the ui elements has a white background, won't it be better to match the background of the layout with that of the parent background instead of resizing the layout ?

CodeChamp-SS on 26 Aug 2020

Ya, you can go for either of the ways! Just make it look better.

garimasingh128 on 26 Aug 2020

so can i take up this issue ?

CodeChamp-SS on 26 Aug 2020

Hey! That's great, however, OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution.

If you want to participate in OSH specifically, I'd suggest you set up all the projects that you're interested to work on first. And meanwhile, you can also work on other issues not labeled "Open Source Hack", because any contribution is good for us!

Do come back on 1st and I'll happily assign you to this issue!

garimasingh128 on 26 Aug 2020

Hey! That's great, however, OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution.

If you want to participate in OSH specifically, I'd suggest you set up all the projects that you're interested to work on first. And meanwhile, you can also work on other issues not labeled "Open Source Hack", because any contribution is good for us!

Do come back on 1st and I'll happily assign you to this issue!

sure

CodeChamp-SS on 26 Aug 2020

Is there any chance I can be assigned this for OSH?

Hyper-Matrix on 26 Aug 2020

I would like to work on this issue...can you please assign this to me for Open-Source Hack?

faznan3nazer on 29 Aug 2020

the layout containing all the ui elements has a white background, won't it be better to match the background of the layout with that of the parent background instead of resizing the layout ?

ss1
ss2

@garimasingh128 I think it looks better now, what do you think ?

CodeChamp-SS on 29 Aug 2020

@Hyper-Matrix @faznan3nazer Yes of course. OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution and please tag project managers to claim issue.

aditmehta9 on 29 Aug 2020

👍1

I would like to work on this issue as a part of OSH. Can you assign me this issue?

Hyper-Matrix on 31 Aug 2020

I would like to work on this issue...can you please assign this to me for Open-Source Hack?

Assigning you @faznan3nazer since @CodeChamp-SS and @Hyper-Matrix have already been assigned an issue

sanchi0204 on 31 Aug 2020

@sanchi0204 can you please assign me to the issue ? i've already worked on the issue and my pr is ready to be made.
I've submitted my pr for the other issue already :-)

CodeChamp-SS on 1 Sep 2020

@sanchi0204 can you please assign me to the issue ? i've already worked on the issue and my pr is ready to be made.
I've submitted my pr for the other issue already :-)

I am sorry @CodeChamp-SS but it has been already assigned. Please explore other issues to work on

sanchi0204 on 1 Sep 2020

docs/ui does not exist under the repo so I am unable to create a PR for this issue. Can you please help me with this
.

faznan3nazer on 3 Sep 2020

docs/ui - that folder is not available, where do I create a pr for this issue?

faznan3nazer on 4 Sep 2020

Can you elaborate which docs/ui folder? You can simply modify this and make a PR.

garimasingh128 on 4 Sep 2020

@garimasingh128 for UI issues aren't OSH participants expected to create a PR with the figma url in an md file under docs/ui? But docs/ui does not exist under the repo.
cc: @anna4j