Mentorship-android: bug: Password change confirmation button enabled only when some password is entered

[jddeep]

Describe the bug
bug: Password change confirmation button enabled only when some password is entered

To Reproduce
Go to settings and Change password

Expected behavior
The button should be disabled at first and then should get enabled once user enters some password.

Screenshots

[jddeep]

I am working on this.

[devanshi7799]

can i work on this?

[Priyansh-Kedia]

May I work on this?

[jddeep]

@mayburgos Can you approve the issue here and get me assigned on it? I was busy with some of my other commitments. Will join the next open sessions to discuss some of my ideas and future of the project. Thanks.

[m-murad]

@jddeep, as you are already working on #568 and some other issues, let @Priyansh-Kedia take this one

@Priyansh-Kedia how would you fix this?

[jddeep]

@m-murad Agreed.
@Priyansh-Kedia You can go ahead.

[Priyansh-Kedia]

@m-murad I would put an if condition check for the empty password fields.
If they will be empty then on click of button there user will be asked to input something in the fields.
I will be applying the textchangedlistener to it.

[m-murad]

What we are doing now is using the default buttons provided by the AlertDialog APIs.
You will need to remove these buttons and add custom buttons in the dialog layout. Then user the textChangedListener on the new password fields.

[Priyansh-Kedia]

@m-murad The problem also gets solved by using textchangedlistener on the default AlertDialog.

[m-murad]

but you will not be able to enable or disable the default buttons, you will have to use custom buttons for that.

[Priyansh-Kedia]

@m-murad I am attaching a clip for what changes I have done till now.
Please suggest.

[m-murad]

Yes, makes sense you can send a PR for review

[Priyansh-Kedia]

@m-murad Thanks.
Sending PR right away.

[Priyansh-Kedia]

@m-murad @mayburgos
https://github.com/anitab-org/mentorship-android/pull/621#issue-384165223
This is the PR for the same.
Please review.
Thanks

[vj-codes]

hey @Priyansh-Kedia how long would it take to send a PR again as discussed?

[Priyansh-Kedia]

@vj-codes
I will try to send a PR by tomorrow

[vj-codes]

@Priyansh-Kedia hey
How's the PR going?

[vj-codes]

@Priyansh-Kedia making it available due to inactivity

[DhaneshShetty]

@vj-codes @anna4j Can I work on this for OSH?

[anna4j]

@DhaneshShetty have you opened a PR for your previous issue?

[DhaneshShetty]

@DhaneshShetty have you opened a PR for your previous issue?

Yes I have @anna4j

[anna4j]

Okay let me just quickly review it and get back to you

[anna4j]

Go ahead with it! @DhaneshShetty assigning you
You can also comment on PR so that I or other mentors know that you've completed your previous issue :)