Is your feature request related to a problem?
This isn't a problem per se, but rather a suggestion on how we can be even more Kotlin-ish.
Currently the app relies heavily on RxJava. It's great, but in Android world coroutines are gaining momentum and... it would be a nice GCI task, to have RxJava code replaced with equivalent Coroutine-based code/
Describe alternatives you've considered
We can just stay with RxJava, it works, too.
I'm not so experienced with RxJava and coroutines but I did search about and coming to think you're right. I think it's available issue and a nice enhancement to the project.
Thanks for raising the issue.
Making this available again if anyone interested in this issue.
I want to work on this issue
I want to work on this issue
OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution
@prayutsu assigning you because you have claimed first and please look at the PR sent earlier before starting.
I want to work on this issue
OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution
So, please assign it on 1st
I want to work on this issue
OSH starts on 1st September and I can't officially assign you just yet. Your PR will be considered for OSH only if you're assigned after 1st. Before that, if I assign you it'll be a regular contribution
So, please assign it on 1st
ok
Can I work on this ?
Can I work on this ?
Assigned you this issue but I'm not sure whether RxJava code should be replaced with Coroutine-based code. Please ask Isabel or Vaishnavi before working on it.
Just throwing in my 2 cents, I converted a big part (if not all) of the networking code to use Coroutines (in #404), and it: simplified code and made it more explicit (and more Kotlin-idiomatic) + less error-prone + made the code ~60% shorter + we also got rid of 1 dependency (RxJava), which I think is good. Coroutines are really cool!
Just throwing in my 2 cents, I converted a big part (if not all) of the networking code to use Coroutines (in #404), and it: simplified code and made it more explicit (and more Kotlin-idiomatic) + less error-prone + made the code ~60% shorter + we also got rid of 1 dependency (RxJava), which I think is good. Coroutines are really cool!
Thanks @bartekpacia
Most helpful comment
Just throwing in my 2 cents, I converted a big part (if not all) of the networking code to use Coroutines (in #404), and it: simplified code and made it more explicit (and more Kotlin-idiomatic) + less error-prone + made the code ~60% shorter + we also got rid of 1 dependency (RxJava), which I think is good. Coroutines are really cool!