Meilisearch: Remove the Maintenance error

Created on 2 Nov 2020  路  3Comments  路  Source: meilisearch/MeiliSearch

Since the health route has been updated, the Maintenance error is not used anymore.

https://github.com/meilisearch/MeiliSearch/blob/4398f2c0234cc6c25910572a8eea59db66c3bb47/meilisearch-http/src/error.rs#L37-L58

Should we remove it?

Related discussion: https://github.com/meilisearch/documentation/pull/564#issuecomment-712812581

Not an emergency of course! 馃檭

picture curquiza

Most helpful comment

we will remove it

picture MarinPostma on 9 Nov 2020
👍3

All 3 comments

Uhmm two options here:

  • Meilisearch-error is a library and this error is just part of the exposed api
  • it's dead code and we should remove it

I'm a partisan of the former.

MarinPostma picture MarinPostma on 2 Nov 2020

I'm not sure what the best practice is in this case, if meilisearch-error is a library it should not be dependant on MeiliSearch's behavior. But we also would like to avoid contributors seeing it and trying to incorporate them in their code, as they did in this PR:
https://github.com/meilisearch/meilisearch-js/pull/635.

bidoubiwa picture bidoubiwa on 3 Nov 2020

we will remove it

MarinPostma picture MarinPostma on 9 Nov 2020
👍3
Was this page helpful?
0 / 5 - 0 ratings

Related issues

creativenull picture creativenull  路  4Comments
Kerollmops picture Kerollmops  路  3Comments
ayalon picture ayalon  路  3Comments
curquiza picture curquiza  路  4Comments
qdequele picture qdequele  路  4Comments