Medusa: {"result": "success"} page on manual search (magnifier icon)
Describe the bug
When clicking the magnifier icon on a show page to launch a forced search of the episode, the result is a blank white page with {"result": "success"}
To Reproduce
Steps to reproduce the behavior:
- Go to a show detail page
- Click on 'the magnifier icon at the end of an episode's line'
- See error
Expected behavior
A "success" message on the episode's line
Screenshots
Medusa (please complete the following information):
Branch: develop Commit: c304860c5360b2e9fa118717a639c28578e5a27e
Version: v0.2.6 Database: 44.11
Python Version: | 2.7.12 (default, Dec 4 2017, 14:50:18) [GCC 5.4.0 20160609]
SSL Version: | OpenSSL 1.0.2g 1 Mar 2016
OS: | Linux-4.12.14-041214-generic-x86_64-with-Ubuntu-16.04-xenial
Locale: | en_US.UTF-8
Additional context
Only on develop branch. Master works fine.
Naokor
All 10 comments
@OmgImAlexis
I'm not having much luck with this bug...
sharkykh
on 24 Jul 2018
This is probably happening because of some other js failure. He should check chrome dev tools console.
p0psicles
on 24 Jul 2018
@p0psicles
The click event handler is missing. That's not a JS error, it's all related to Vue.
It's taking over the DOM too early, I think.
sharkykh
on 24 Jul 2018
Ive had the issue before. And i think it was a race condition. I dont think its vue related.
We could make sure its not following the link, when the click event hasnt been overeritten yet.
p0psicles
on 24 Jul 2018
Hmm these are generated now by the app-link.
Still remember to have seen this issue before they where changed to app-link.
p0psicles
on 24 Jul 2018
You're talking about the links in the snatchSelection and the recommended shows pages. Because it was loading part of the page using jQuery, and Vue can't render new components on the fly.
It's a different issue.
sharkykh
on 24 Jul 2018
I think we could easily fix this, by adding a property to the app-link component, to remove the click handler.
p0psicles
on 24 Jul 2018
No, i'm talking about the links in displayShow. The app-link is generating an with an href. Then ajax-ep-search.js goes over all the .epSearch and .epManualSearch classes, and binds new click handlers.
If you click the icon before the new events have been bind, your just following the link. Which is returning the json.
p0psicles
on 24 Jul 2018
ajax-ep-search.js there is your issue. Move the button to a new component that handles manual search instead of using an app-link since it's not a link.
OmgImAlexis
on 25 Jul 2018
Fixed with #4751.
sharkykh
on 25 Jul 2018
Related issues
a10kiloham
路
3Comments
LoRNiKoN
路
4Comments
skarekrow
路
4Comments
Rouzax
路
4Comments
Shootersss
路
3Comments