Mediaelch: Fixed spacing between icons

[psonnosp]

Describe the bug
See thescreenshot.
Installed 2.6.2 stable and all of a sudden there's a gigantic spacing between the icons for the different artworks and if I don't make the column wide enough so they all show three dots cover the episode counter under the episode name. And to make it wide enough the column covers like half the screen.

To Reproduce
Steps to reproduce the behavior:
It's there in plain sight so nothing needed for reproducing it.

Expected behavior
There shouldn't be a fixed spacing between the icons so they can be showed together without covering the episode counter.

Screenshots

MediaElch Version:

• [ ] 2.6.3-dev (nightly)
• [X] 2.6.2 stable
  

Operating System:

• [X] Windows
• [ ] macOS
• [ ] Linux (distribution: ___)

Additional context
Add any other context about the problem here.

[ticao2]

In Movies, apparently, in version 2.6.2 and 2.6.1, the space between icons was 3 times larger than in version 2.6.0.

[bugwelle]

I encountered this issue on different platforms as well. It's a strange issue because I don't have this kind of problem on macOS. I currently don't know whether this is an issue caused by a new Qt version or a change on my side.

Thank you for opening this issue. :-)

[bugwelle]

Just did some debugging (tested commits that didn't even arrange the icons this way). It's due to a Qt update. I'll look into how we can fix this.

[bugwelle]

As far as I can tell, it's because icons are drawn next to the cells content... which is empty. We draw icons by using DecorationRole instead of DisplayRole. We may fix this by implementing a custom Delegate class to draw these icons.

[bugwelle]

I know that this bug is still open. I wasn't able to fix this issue, yet and it's driving me crazy. 😄
I don't think this will be fixed in v2.6.6, but maybe in a later version.

[psonnosp]

I've moved on to 16:9 screens now so it's no longer a problem. Not for me atleast so no worries, but I get the feeling 😉

[bugwelle]

I FINALLY found the issue... Such a stupid one. I set the column width to 22px but the _minimum_ column width (the default) was 41px. It must have changed in some Qt version.

Will be fixed by #1266

[psonnosp]

Congrats! Better late than never 😉

[bugwelle]

Thanks. So annoying, the documentation didn't even list the default value...
https://doc.qt.io/qt-5/qheaderview.html#minimumSectionSize-prop

I'll publish a new Nightly shortly.