Mbed-os: SPI: FPGA CI: test regression

[yarbcy]

Description of defect

SPI: FPGA CI: test regression

First regression:
From commit fd05ebf96ddcee3e231dd602abfd176b3d4ed2c7 (PASS) to ba12228556bbac4b8e0b9819a94a946513babecc (FAIL)
Diff: github.com/ARMmbed/mbed-os/compare/fd05ebf96ddcee3e231dd602abfd176b3d4ed2c7...ba12228556bbac4b8e0b9819a94a946513babecc

Proposed fix:
Line 130 -136:
//if (init_direct) {
//const spi_pinmap_t pinmap = get_spi_pinmap(mosi, miso, sclk, ssel);
//spi_init_direct(&spi, &pinmap);
//} else {
spi_init(&spi, mosi, miso, sclk, ssel);
//}
After this code change - all 12 test cases PASSED.

Second regression:
From commit b2dad08 to master.
Diff:
https://github.com/ARMmbed/mbed-os/compare/b2dad08...master#files_bucket

Fix (above) doesn't help in this case.

Fail log:
FPGA_CI_CY8CKIT_062_WIFI_BT.txt

Target(s) affected by this defect ?

CY8CKIT_062_WIFI_BT

Toolchain(s) (name and version) displaying this defect ?

GCC_ARM

What version of Mbed-os are you using (tag or sha) ?

5d64e558801940b3be547c3d059f28eaabc23f95

What version(s) of tools are you using. List all that apply (E.g. mbed-cli)

N/A

How is this defect reproduced ?

1. Run FPGA CI Automated tests.
2. Connect FPGA CI board
3. mbed test -m CY8CKIT_062_WIFI_BT -t GCC_ARM -n tests-mbed_hal_fpga_ci_test_shield-spi

[yarbcy]

@adbridge Please review.

[adbridge]

@yarbcy
'What version of Mbed-os are you using (tag or sha) ?
See above.

This will fail the automated checks. Please follow the guidelines and put a specific version in this field.

Also

'How is this defect reproduced ? '

This should be a list of steps that you run to produce this error .

[yarbcy]

@yarbcy
'What version of Mbed-os are you using (tag or sha) ?
See above.

This will fail the automated checks. Please follow the guidelines and put a specific version in this field.

Also

'How is this defect reproduced ? '

This should be a list of steps that you run to produce this error .

Done.

[ciarmcom]

Internal Jira reference: https://jira.arm.com/browse/IOTOSM-467

[0xc0170]

cc @mprse

[0xc0170]

cc @mprse

We'll need to allocate this to different person.

[0xc0170]

cc @jamesbeyond Can you help with this one?

[jamesbeyond]

cc @jamesbeyond Can you help with this one?
Yep, I am assigning this one to me

[jamesbeyond]

Hi @yarbcy,

I think the main issue caused by we introduced the static pinmap function to mbed-os for saving flash usage in run time. Static Pinmap
the test for the FPGA shield tests trends to use the static pinmap. But the target CY8CKIT_062_WIFI_BT and all the cypress target did not have this feature enabled. so that the reason the tests are failing.

So I would suggest to cypress team to enable the static pinmap following by design docs: Static Pinmap. the only work that need to be done is spilt the exist spi_init() function into aspi_init() and a spi_init_direct() function. then the tests would be passed.