Mbed-os: Bring CI specific modules into requirements.txt?

Created on 12 Feb 2019  路  6Comments  路  Source: ARMmbed/mbed-os

Description

@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers

Thoughts about bringing in the CI-only requirements permenantly into Mbed OS's requirements.txt?
Basically, moves https://github.com/ARMmbed/mbed-os/blob/master/.travis.yml#L111 into https://github.com/ARMmbed/mbed-os/blob/master/requirements.txt

CC @JuhPuur

Issue request type


[x] Question
[ ] Enhancement
[ ] Bug

CLOSED mirrored

Most helpful comment

I initially thought this was the case until travis broke and we found out about python modules there.

Aren't there "test reqs" ? install_requires - requirements.txt, test_requires - test_requirements.txt , would this be good ? Rather than all in one?

Quick search, https://github.com/influxdata/influxdb-python (following test/dev/install req) - similar what I had on mind.

All 6 comments

I initially thought this was the case until travis broke and we found out about python modules there.

Aren't there "test reqs" ? install_requires - requirements.txt, test_requires - test_requirements.txt , would this be good ? Rather than all in one?

Quick search, https://github.com/influxdata/influxdb-python (following test/dev/install req) - similar what I had on mind.

Yeah what @0xc0170 said, please use a separate test_requirements.txt, this is a common practice (we use it in mbed-os-tools!).

馃槥 I don't like adding _even more_ things into the root of the project.

Will look into making a PR.

Although I'm wondering...

I suspect that running seperate pip install -r invocations could yield different dependencies than a single pip install -r <merged_file>.

I don't like adding _even more_ things into the root of the project.

You can put it wherever you want, doesn't have to be in the root 馃槃

I suspect that running seperate pip install -r invocations could yield different dependencies than a single pip install -r <merged_file>.

Not 100% sure, but I'd think it'd be fairly reasonable. You can also supply multiple -r arguments to pip install:

$ pip install --help
...
Install Options:
  -r, --requirement <file>    Install from the given requirements file. This
                              option can be used multiple times.
...

@cmonr It sounds like both @bridadan and @0xc0170 prefer separate file. I'll keep this closed unless you still feel strongly about your proposal, in which case, feel free to reopen it.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

chrissnow picture chrissnow  路  4Comments

cesarvandevelde picture cesarvandevelde  路  4Comments

bcostm picture bcostm  路  4Comments

davidantaki picture davidantaki  路  3Comments

bcostm picture bcostm  路  4Comments