Mbed-os: emac: files do not contain license description

Created on 24 Jan 2019  路  12Comments  路  Source: ARMmbed/mbed-os

Description

Files in features/netsocket/emac-drivers/, for instance features/netsocket/emac-drivers/TARGET_NXP_EMAC/TARGET_IMX/imx_emac.h do not contain SPDX identifier neither license description

@ARMmbed/mbed-os-ipcore Please review

Issue request type


[ ] Question
[ ] Enhancement
[X] Bug

CLOSED mirrored bug

All 12 comments

Also features/netsocket/emac-drivers/TARGET_NXP_EMAC/TARGET_LPCTarget/lpc17_emac.cpp - does not contain any license information

@TomoYamanaka features/netsocket/emac-drivers/TARGET_RZ_A1_EMAC/rza1_emac.cpp does not contain Copyright header. Please add.

This is contribution from Renesas, so I cannot claim the copyright to it.

@svastm Please add Copyright header to features/netsocket/emac-drivers/TARGET_STM_EMAC/TARGET_STM32F4/TARGET_MODULE_UBLOX_ODIN_W2/stm32f4_eth_init.cpp as the file is originally submitted by you. Thanks.

@ARMmbed/team-ublox Please add copyright header to TARGET_STM_EMAC/TARGET_STM32F4/TARGET_MODULE_UBLOX_ODIN_W2/wifi_emac/wifi_emac.cpp

I found only one driver that I can fix, and submitted a PR in https://github.com/ARMmbed/mbed-os/pull/9834

Rest are contributions from mentioned parties, and we should wait for them to submit the Copyright header.

@svastm Please add Copyright header to features/netsocket/emac-drivers/TARGET_STM_EMAC/TARGET_STM32F4/TARGET_MODULE_UBLOX_ODIN_W2/stm32f4_eth_init.cpp as the file is originally submitted by you. Thanks.

@ARMmbed/team-st-mcd

@ARMmbed/team-ublox Please add copyright header to TARGET_STM_EMAC/TARGET_STM32F4/TARGET_MODULE_UBLOX_ODIN_W2/wifi_emac/wifi_emac.cpp

@ARMmbed/team-ublox

Hi
@svastm is no more part of ST :-(
but as file is UBLOX one, I let @ARMmbed/team-ublox provide both patches in the same PR
Regards,

This issue is still valid (I checked stm32f4_eth_init.cpp).

@ARMmbed/team-ublox Can you fix license headers in your files please? This issue could be closed once fixed.

cc @maclobdell

@0xc0170 sure in next PR

This can be closed, all files were updated.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

drahnr picture drahnr  路  4Comments

davidantaki picture davidantaki  路  3Comments

DuyTrandeLion picture DuyTrandeLion  路  3Comments

cesarvandevelde picture cesarvandevelde  路  4Comments

ghost picture ghost  路  4Comments