Mbed-os: Component_SD tests fail on master branch

[deepikabhavnani]

Description

Tests under component_sd are failing build when compiled with below error:

mbed test --compile -m K64F -t GCC_ARM -n mbed-os-components-storage-blockdevice-component_sd-test*

Failure log
Build failures:

• K64F::GCC_ARM::MBED-OS-COMPONENTS-STORAGE-BLOCKDEVICE-COMPONENT_SD-TESTS-FILESYSTEM-FOPEN
  [Warning] @,: Compiler version mismatch: Have 7.3.1; expected version >= 6.0.0 and < 7.0.0
  Building project fopen (K64F, GCC_ARM)
  Scan: GCC_ARM
  Scan: fopen
  Compile [100.0%]: fopen.cpp
  [Fatal Error] fopen.cpp@28,10: fsfat_debug.h: No such file or directory

• K64F::GCC_ARM::MBED-OS-COMPONENTS-STORAGE-BLOCKDEVICE-COMPONENT_SD-TESTS-FILESYSTEM-PARALLEL
  [Warning] @,: Compiler version mismatch: Have 7.3.1; expected version >= 6.0.0 and < 7.0.0
  Building project parallel (K64F, GCC_ARM)
  Scan: GCC_ARM
  Scan: parallel
  Compile [100.0%]: main.cpp
  [Warning] main.cpp@108,21: array subscript has type 'char' [-Wchar-subscripts]
  [Warning] main.cpp@120,25: array subscript has type 'char' [-Wchar-subscripts]
  [Warning] main.cpp@124,21: array subscript has type 'char' [-Wchar-subscripts]
  [Warning] main.cpp@135,21: array subscript has type 'char' [-Wchar-subscripts]
  [Warning] main.cpp@139,25: array subscript has type 'char' [-Wchar-subscripts]
  [Warning] main.cpp@151,21: array subscript has type 'char' [-Wchar-subscripts]
  [Error] main.cpp@157,43: 'OS_STACK_SIZE' was not declared in this scope
  [Error] main.cpp@161,5: 'Thread' was not declared in this scope
  [Error] main.cpp@161,13: 'data' was not declared in this scope
  [Error] main.cpp@169,34: expected type-specifier before 'Thread'
  [Warning] main.cpp@170,86: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  [Error] main.cpp@177,34: expected type-specifier before 'Thread'
  [Warning] main.cpp@178,85: cast to pointer from integer of different size [-Wint-to-pointer-cast]

Also noted these tests are not executed as part of CI testing,

Issue request type

[ ] Question
[ ] Enhancement
[X] Bug

CC @ARMmbed/mbed-os-storage

[cmonr]

Looks like they're being excluded on purpose in the CI: https://github.com/ARMmbed/mbed-os-ci/blob/master/mbed-os-jenkins/mbed-os-ci-greentea-test/Jenkinsfile.groovy#L58 (Private repo link)

Makes me wonder which came first, the broken tests, or the CI disablement.

In any case @ARMmbed/mbed-os-test-team, once these tests are fixed in master, is there anything else needed to enable them in CI?

[ciarmcom]

Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-309

[yossi2le]

This is strange. I cloned the master on my machine and run your compilation command. It compiles without any error. the only difference is that I cant run it with -n mbed-os-components-storage-blockdevice-component_sd-test* and I had to remove the mbed-os from the beginning: -n components-storage-blockdevice-component_sd-test*
Are you compiling the mbed-os as part of an application?

Build successes:

• K64F::GCC_ARM::COMPONENTS-STORAGE-BLOCKDEVICE-COMPONENT_SD-TESTS-FILESYSTEM-DIRS
• K64F::GCC_ARM::COMPONENTS-STORAGE-BLOCKDEVICE-COMPONENT_SD-TESTS-FILESYSTEM-FILES
• K64F::GCC_ARM::COMPONENTS-STORAGE-BLOCKDEVICE-COMPONENT_SD-TESTS-FILESYSTEM-FOPEN
• K64F::GCC_ARM::COMPONENTS-STORAGE-BLOCKDEVICE-COMPONENT_SD-TESTS-FILESYSTEM-PARALLEL
• K64F::GCC_ARM::COMPONENTS-STORAGE-BLOCKDEVICE-COMPONENT_SD-TESTS-FILESYSTEM-SEEK
• K64F::GCC_ARM::MBED-BUILD

[deepikabhavnani]

Forgot to leave a note, I was in bootloader project when I saw the error and failed to realize that rtos was in ignore list and hence the failure.