Mbed-cli: Replace SHAs with git refs in .lib files
This is related to PR https://github.com/ARMmbed/mbed-cli/pull/565, but not dependent on it.
This is an enhancement that:
- should help clarify exactly what versions/releases all .lib repos are at, and
- allows for shallow clones in https://github.com/ARMmbed/mbed-cli/pull/565 to function, since the SHA must be tied to a git ref.
cmonr
All 3 comments
You're referring to tags, not branches, correct?
theotherjimmy
on 28 Nov 2017
Actually, branches could be used as well (branch heads).
If the reference is listed under git ls-remote, then it can be directly fetched from the remote, either from the ref name or the SHA.
But I would think that release tags would/should be the main use case.
cmonr
on 28 Nov 2017
@cmonr We have a policy of not allowing branches in .lib and .bld files, as they _can move_. We have defined library references to be fixed, and updates require _explicit_ user requests. As such, I can't accept a PR that automatically swaps a SHA ref; slow clone, can't change meaning; to a branch ref; fast clone, can change meaning.
theotherjimmy
on 28 Nov 2017
Related issues
toyowata
路
8Comments
sillevl
路
10Comments
bremoran
路
4Comments
teetak01
路
10Comments
stevew817
路
7Comments
Most helpful comment
@cmonr We have a policy of not allowing branches in
.liband.bldfiles, as they _can move_. We have defined library references to be fixed, and updates require _explicit_ user requests. As such, I can't accept a PR that automatically swaps a SHA ref; slow clone, can't change meaning; to a branch ref; fast clone, can change meaning.