Mattermost-server: Private channels should appear in channel link autocomplete

[mattermod]

Environment: Firefox/Mac on community-daily

Repro steps:
1) Create a private channel named privatechannel
2) In the post textbox, type ~priv

Observed: No autocomplete entry appears for ~privatechannel or any other private channel
Expected: An autocomplete entry appears for ~privatechannel. If users viewing the post are a member of the linked channel, then show it as a link, if not it should appear as normal text (as to not give away that the channel exists)

Note we should do a load test on a server with a lot of private channels to check perf degradation on this

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-18496

[CCCCY096]

Hi, I'd like to take this ticket!
:)

[esethna]

@CCCCY096 all yours!

[CCCCY096]

Hello, I'm trying to find the documentation regarding the SQL schema "Channels" and "ChannelMembers" in function channel_store.go/AutocompleteInTeamForSearch. Could you provide more documentation on how these two SQL tables are structured and how to query private channels?
Also, is it possible to join the developer community? It seems like the invitation link provided is not valid: https://community.mattermost.com/signup_user_complete/?id=f1924a8db44ff3bb41c96424cdc20676

Thanks a lot!

[esethna]

@agnivade may be able to help ^

[agnivade]

Hi @CCCCY096 - Depending on the database you are using, the easiest way to check the schema is to just login to your DB and see the schema for the Channels and ChannelMembers table.

However, here is the place where the tables get created from code:
https://github.com/mattermost/mattermost-server/blob/819b4b8e7ba4681b2e1f1a785bfdd9a47a2d3726/store/sqlstore/channel_store.go#L366-L376

https://github.com/mattermost/mattermost-server/blob/819b4b8e7ba4681b2e1f1a785bfdd9a47a2d3726/store/sqlstore/channel_store.go#L378-L382

https://github.com/mattermost/mattermost-server/blob/819b4b8e7ba4681b2e1f1a785bfdd9a47a2d3726/store/sqlstore/channel_store.go#L411-L415

https://github.com/mattermost/mattermost-server/blob/819b4b8e7ba4681b2e1f1a785bfdd9a47a2d3726/store/sqlstore/channel_store.go#L422-L423