Mattermost-server: LRU cache: consider doing serialization/deserialization operations out of critical section
Our LRU cache get/set calls do the entire operation inside the critical section. But that鈥檚 really not necessary. Only the components of the LRU cache need to be guarded.
The serialization/deserialization operations can move outside the locked sections to possibly ease the lock contention time and increase overall throughput.
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
mattermod
All 4 comments
/cc @Leryan @rvillablanca in case any of you are interested.
If anyone wants more help/clarification, please feel free to comment here and I can clarify further.
agnivade
on 30 Oct 2020
@agnivade I would like to try my hand at this.
I believe changes would be inside /services/cache/lru.go ?
Let me know.
akshaychhajed
on 30 Oct 2020
Yep, that's correct!
agnivade
on 30 Oct 2020
Ok. I will work on this.
Thank you @agnivade @Leryan @rvillablanca
akshaychhajed
on 31 Oct 2020
Related issues
esethna
路
3Comments
NotSqrt
路
3Comments
tumbl3w33d
路
3Comments
jasonblais
路
3Comments
esethna
路
3Comments
Most helpful comment
@agnivade I would like to try my hand at this.
I believe changes would be inside /services/cache/lru.go ?
Let me know.