Mattermost-server: mattermod: move away from gorp to sqlx in pull_request_store.go

Created on 23 Sep 2020  路  3Comments  路  Source: mattermost/mattermost-server

We are planning to move away from gorp to using sqlx in our server repo to perform any SQL queries. And doing that change in mattermod is the first step in getting some experience in doing that.

Mattermod is a relatively small codebase with just 3 tables.

This PR is about migrating the pullrequeststore.go to use sqlx. Here is a dummy PR https://github.com/mattermost/mattermost-mattermod/pull/241 which gives an outline of how to do that.

Once you have done that, your local unit tests should pass. That is enough indication that the migration has been done. There is NO need to run and test mattermod end to end for this.

Essentially, we need to move away from using gorp methods to using sqlx methods.

If you have questions about the ticket or you need any help, feel free to contact agniva.de.sarker in https://community.mattermost.com/


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-28977

Hacktoberfest Help Wanted PR Exists TecGo

All 3 comments

I release this issue since I haven't had time to work on this.

@kashifsoofi - Wondering if you are up for this and drive home a clean run finishing all the stores in mattermod? :)

@kashifsoofi - Wondering if you are up for this and drive home a clean run finishing all the stores in mattermod? :)

Sounds good, i can take this.

Was this page helpful?
0 / 5 - 0 ratings