Mattermost-server: Remove usage of jQuery from settings modals

Created on 31 Jul 2020  路  4Comments  路  Source: mattermost/mattermost-server

We've been working for some time to remove jQuery as a dependency of the Mattermost web app to reduce the size of the JS bundle in the web app and to simplify our code by using equivalent functions that are usable on all browsers that we support.

As part of this, we should remove the usage of jQuery from the following files in the web app:

  • components/activity_log_modal/activity_log_modal.jsx
  • components/settings_sidebar.tsx
  • components/team_settings_modal/team_settings_modal.jsx

In addition to removing the usage of jQuery, an E2E test using Cypress should be added to ensure that:

  • When revoking a session from Account Settings > Security > View and Log Out of Active Sessions, the modal should still flash yellow.
  • When using mobile view (triggered when the window is less than 768 pixels wide), you should still be able to navigate Account Settings and Team Settings correctly

If you have any questions, feel free to ask @hmhealey (or @harrison on our Mattermost community server).


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-27445

Easy Help Wanted TecReactJS

Most helpful comment

Working on this.

All 4 comments

Hey,
I'd like to work on this

Thanks for the help on this, @breditter!

Let us know if you have any questions about getting set up for this. You can either post a message here or join us on https://community.mattermost.com if you need help.

This issue appears stale. and I鈥檓 adding the Up For Grabs label. If work is ongoing, please remove the label. If there is an existing PR, please also link it to the issue. Thanks!

Working on this.

Was this page helpful?
0 / 5 - 0 ratings