Mattermost-server: SMTP test emails & password reset emails are not sent when email notifications are off

[aidenmitchell]

Per Mattermost guidelines, GitHub issues are for bug reports: http://www.mattermost.org/filing-issues/.

For troubleshooting see: http://forum.mattermost.org/.
For feature proposals see: http://www.mattermost.org/feature-requests/

If you've found a bug--something appears unintentional--please follow these steps:

1. Confirm you’re filing a new issue. Search existing tickets in Jira to ensure that the ticket does not already exist.
2. Confirm your issue does not involve security. Otherwise, please see our Responsible Disclosure Policy.
3. File a new issue using the format below. Mattermost will confirm steps to reproduce and file in Jira, or ask for more details if there is trouble reproducing it. If there's already an existing bug in Jira, it will be linked back to the GitHub issue so you can track when it gets fixed.

Summary

SMTP test emails & password reset emails are not sent when email notifications are off.

Steps to reproduce

1. Setup SMTP
2. Disable email notifications
3. Test SMTP using the Test Connection button
4. Enable email notifications
5. Test SMTP using the Test Connection button

OR

1. Setup SMTP
2. Disable email notifications
3. Request a password reset email.
4. Enable email notifications
5. Request a password reset email.

Expected behavior

I receive a test email. Users receive a password reset email.

Observed behavior (that appears unintentional)

I do not receive a test email. Users do not receive a password reset email when requested.

[amyblais]

@aidenmitchell What server version are you on?

[agnivade]

This is likely a duplicate of https://mattermost.atlassian.net/browse/MM-26033.

[aidenmitchell]

@amyblais Version 5.24.2

[aidenmitchell]

@amyblais I don't believe PR #15022 solves the password reset email part of this issue.

[agnivade]

@isacikgoz - Did you get a chance to chat with @thefactremains about this? :point_up:

[isacikgoz]

@amyblais I don't believe PR #15022 solves the password reset email part of this issue.

Just got the chance to review this. So, yes that PR is for SMTP testing part of the issue. The remaining part, however, doesn't seem to be related with the SendEmailNotifications setting.

[amyblais]

Ok, I created a ticket for the other case: https://mattermost.atlassian.net/browse/MM-27349.

[agnivade]

Hi @aidenmitchell - the test email does seem to be part of the SendEmailNotifications, but the password reset is not. I just tested it with the setting being off and I can see password reset mails being sent properly.

Would you be able to provide additional logs that can help us debug this issue further?

[agnivade]

Both the tickets are resolved now. @aidenmitchell - would you be able to clarify my comment above?