Mattermost-server: If a plugin registered a custom tooltip, clicking hashtags to have no effect

Created on 7 May 2020  路  5Comments  路  Source: mattermost/mattermost-server

I can reproduce this with the demo plugin. Enabling the demo plugin causes hash tags not to work because of the registered LinkTooltip component. I don't know the exact cause, but it I believe it's related to this hook because it is having the same effect in my personal plugin I'm working on as well that uses the same hook. Disabling the demo plugin and refreshing the page makes it so hash tags work again.

https://github.com/mattermost/mattermost-webapp/pull/2386 originally introduced plugin custom tooltips.


If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-24761

AreToolkit Medium Help Wanted PR Exists TecReactJS

All 5 comments

The href is broken
github.com/mattermost/mattermost-webapp/pull/2386%7Csmart-link
have got 404

https://github.com/mattermost/mattermost-webapp/pull/2386 originally introduced plugin custom tooltips.

@Chubik Eagle eyes, fixed it :+1:

@mickmister 9 days have passed no one grabbing this. Would you please take a look?

@hanzei I've found the issue and have a branch with a fix. Will create a PR within the next few days. There will likely need to be some discussion around the solution.

Thanks for the quick fix @mickmister. :+1: Given that the github plugin makes use of the tooltip feature in https://github.com/mattermost/mattermost-plugin-github/pull/258, it would be great to get the fix into 5.24.

Was this page helpful?
0 / 5 - 0 ratings