Mattermost-server: Improve Announcement banner tooltip behavior

Created on 29 Apr 2020  路  8Comments  路  Source: mattermost/mattermost-server

Announcement banner display tooltips to show the content when it exceeds one line and is truncated. The current behavior is redundant and always show tooltips for Announcement banners even when the text isn't truncated.

Observed
Tooltips always display when a user hovers over an Announcement banner, even when the text isn't truncated.

image

Expected

  • Only show the tooltip if the text in the banner truncates
  • Fix the z-index of the tooltip, it sits behind the banner

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-16068

AreEnd User Feature Easy Help Wanted PR Exists TecReactJS

Most helpful comment

done @jasonblais

All 8 comments

@hanzei would like to take this up.

@amyblais could you share the screenshot mentioned in the description. I am unable to see it.

/cc @esethna ^

@amyblais @fullstackguyhere updated. Image is in the JIRA ticket linked. Thanks for taking the ticket :)

@esethna @hanzei @amyblais I have PR ready for this, I have submitted my details by accepting Mattermost Contributor License Agreement. Could anyone accept it so that I can submit my PR?

@fullstackguyhere no need to wait, and I've now confirmed the CLA is submitted correctly. Feel free to go ahead with the PR :tada:

Huge thank you for the help!

Thanks @jasonblais, will do it today.

done @jasonblais

Was this page helpful?
0 / 5 - 0 ratings