Mattermost-server: Bot icon image has too much height

[mattermod]

Bot accounts can use custom icons, which was added in https://github.com/mattermost/mattermost-server/pull/11423. But the icon styling is broken and has to much height. This ticket is about fixing the broken styling.

Repo steps:

1. Check out branch 262_ensure-bot from Matterpoll
2. Deploy plugin
3. DM with Matterpoll Bot

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-22764

[allenlai18]

i can look into this. we want the matterpoll to be the exact same height as the other bots?

[hanzei]

Thanks @allenlai18 :+1:

Yes, the icon should be the same height as other bot icons. Just to be clear: This is not a bug in Matterpoll, Matterpoll is only the example I'm using here.

[allenlai18]

how do i deploy the plugin? and how do i get the matterpoll to show up on the LHS

[hanzei]

@allenlai18

• Clone Matterpoll Repo
• git checkout 262_ensure-bot
• make dist
• Upload the bundle under dist/com.github.matterpoll.matterpoll-1.3.0.tar.gz to Mattermost
• Enable the plugin

Does this help getting the plugin set up?

[allenlai18]

i see that i need a site URL to enable the plugin right? what should i set my site url to? when i set it to example.com:8065 i get This is not a valid live URL

[hanzei]

@allenlai18 Are you using a standard dev environment? The the site URL should be http://localhost:8065

[allenlai18]

i think theres something wrong with the build of the plugin

[hanzei]

@allenlai18 Good catch :+1: I fixed the build

[hanzei]

@allenlai18 Did my latest changes allowed you to build and deploy the plugin?

[allenlai18]

@allenlai18 Did my latest changes allowed you to build and deploy the plugin?

@hanzei yes. let me take a look at this

[14Richa]

Hey team, i wish to work on this issue. Is this already taken? Can you tell me the status of this issue?

[hanzei]

It seems like @allenlai18 is not longer working on this. @14Richa feel free to take it.

[hanzei]

@14Richa Are you still working on this?

[hanzei]

Fixed with https://github.com/mattermost/mattermost-webapp/pull/6578