Mattermost-server: Return error in parseDSN func

Created on 21 Feb 2020  路  3Comments  路  Source: mattermost/mattermost-server

https://github.com/mattermost/mattermost-server/blob/17f2cd665dec34b96c8f980c0035d70b8f557109/config/database.go#L138-L144

I ran into this code snippet while checking error handling logic in mattermost-server. It looks like at L142, an error is created but never handled or returned. Is this by purpose or just a minor bug?

AreDB Easy Good First Issue Help Wanted PR Exists TecGo
Source
picture upwell

All 3 comments

Good find @upwell! I believe that does look like a bug, that line should be returning an error. I believe that was updated as part of https://github.com/mattermost/mattermost-server/pull/12250/files

ali-farooq0 picture ali-farooq0 on 25 Feb 2020
👍1

Turning this into a help-wanted issue. @upwell will you be up for working on this issue before i make it available to public?

ali-farooq0 picture ali-farooq0 on 25 Feb 2020

@ali-farooq0 Sure. I will work out a PR for this issue. Returning the error could fix this issue.

upwell picture upwell on 27 Feb 2020
👍1
Was this page helpful?
0 / 5 - 0 ratings

Related issues

esethna picture esethna  路  3Comments
esethna picture esethna  路  3Comments
esethna picture esethna  路  3Comments
jasonblais picture jasonblais  路  3Comments
esethna picture esethna  路  3Comments