Mattermost-server: Add a count for pinned posts header icon

[mattermod]

Current implementation missed webapp, but server and mobile are done: https://github.com/mattermost/mattermost-server/issues/10145

Add a count, similar to the channel member icon, to the pinned post icon in the channel header.

The count should increment when a post is pinned and decrement when a post is unpinned.

---

If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.

New contributors please see our Developer's Guide.

JIRA: https://mattermost.atlassian.net/browse/MM-10272

[sowmiyamuthuraman]

Would like to work on this!

[hanzei]

Awesome, thanks @sowmiyamuthuraman :tada:

[sowmiyamuthuraman]

@hanzei the redux actions to update the pinnedpost_count of ChannelStats when a post is pinned or unpinned are not implemented in mattermost-redux. Bcoz of that the count of the pinned posts are not reflecting the correct number as soon as the post is pinned or unpinned. shall I raise a PR for that referencing this issue?

[hanzei]

@sowmiyamuthuraman I have to admit that I don't know enough about redux to answer this question. @hmhealey can you please jump in?

[hmhealey]

How are the other fields of the ChannelStats object (like the member count and guest count) updated? What you suggested makes sense to me unless we do something really different for the other fields.

[sowmiyamuthuraman]

How are the other fields of the ChannelStats object (like the member count and guest count) updated? What you suggested makes sense to me unless we do something really different for the other fields.

@hmhealey other fields like member count are updated as soon as a member is added or removed from the channel. similarly, we can do for the pinned posts count also.

[hmhealey]

It looks like the member count is updated by requesting the latest channel stats when the app receives a websocket event that a user was added to the channel. Here is where the web app's websocket code does that and here is where the mobile app's websocket code does it for reference.

[sowmiyamuthuraman]

It looks like the member count is updated by requesting the latest channel stats when the app receives a websocket event that a user was added to the channel. Here is where the web app's websocket code does that and here is where the mobile app's websocket code does it for reference.

@hmhealey I am referring something similar to this. Is it not required for the pinned posts count?

[hmhealey]

Oh yeah, it would be good to be clear that the pinned post count should be changed when you pin or unpin a post. You'll also need to add handing for the corresponding websocket event though since that handles when another user pins a post.

[sowmiyamuthuraman]

Oh yeah, it would be good to be clear that the pinned post count should be changed when you pin or unpin a post. You'll also need to add handing for the corresponding websocket event though since that handles when another user pins a post.

Thanks @hmhealey will do that!