We are starting to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify all files in components/dot_menu (not sub-directories included) and associated test files.
Below is a checklist of items you should be doing to migrate:
js to ts, jsx to tsx)make check-types to display any errors.We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.
Some examples of already migrated files can be found here:
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
JIRA: https://mattermost.atlassian.net/browse/MM-20513
Here is a start of a PR to help you get started: https://github.com/mattermost/mattermost-webapp/pull/5451
Hi @devinbinnie I'd like to be assigned this please
Sure thing!
Are you still working on this issue @strtw ?
@hanzei Apologies for the late reply, I am still working on this.
Thanks for the update @strtw :+1:
@strtw We have another contributor interested in working on this, as it is needed for another migration. How are things going?
@devinbinnie I have made some progress, but don't know TS that well so it's been slow. I wouldn't mind if someone else took over though. What's the best way for me to share my work in progress in case the new contributor would like to use it?
@strtw You can create a draft PR for this issue, that will make your code public and easy for all to see.
For anyone who may be interested, this ticket is up for grabs. Here is a start of a PR to help you get started: https://github.com/mattermost/mattermost-webapp/pull/5451
I would like to take a crack at this if its still open.
awesome, thanks @vraravam!