We are starting to migrate the mattermost-webapp over to TypeScript to facilitate better code quality. This Help Wanted issue is to modify all files in components/emoji_picker (not sub-directories included) and associated test files.
Below is a checklist of items you should be doing to migrate:
js to ts, jsx to tsx)make check-types to display any errors.We are aiming to be as strict as possible for the time being, but if you run into any issues where the file cannot be successfully migrated without significant change in other libraries, or our tsconfig.json, please feel free to raise them as we are aiming to keep this process smooth and gradual, while enforcing as much as we can.
Some examples of already migrated files can be found here:
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
I would like to take this,
Oh, sorry @pankajhirway, I was already working here https://github.com/mattermost/mattermost-webapp/pull/3648
@cometkim oh ok, Please go ahead and assign it to yourself. I haven't started on it. Thank you for letting me know. :)
Hi @cometkim! Do you want to work on this or shall I open it back Up For Grabs? Hope you've been well :)
Hi @jfrerich
I asked the core team from https://github.com/mattermost/mattermost-webapp/pull/3648 to resolve another related issue but it seems have not been resolved yet.
Another issue is the fact that the images contained in the emoji data used by Mattermost violate Apple's license terms. It is important to understand that contributing to code that uses it poses a risk to individual contributors.
So I want to migrate it to open source emoji-data and use other images/emoji-fonts or just system fonts, but Mattermost's emoji codebase is pretty complicated.
It seems better suited for the core team. After resolving issues across the webapp and the redux, it will be easier for other contributors to improve the emoji picker.
Emoji picker shares state and actions with others widely, so if we try to migrate it will make some pretty big changes.
I don't have a plan to work on this issue but I don't sure about to make it "Help Wanted", "Good First Issue" or "Up For Grabs"
This typescript conversion does seem very large because of all the sharing of the component. Although it might seem a large task I feel like it would be a good project for someone to tackle. What do you think about opening this ticket back Up For Grabs and change the difficulty label from Easy to Medium?
@jfrerich It makes sense to me :ok_hand: and Good first issue should be removed I think