Mattermost is increasing the unit test coverage for the mmctl CLI tool. Through the use of a mocked client that will simulate the interactions with the server, the goal is to create a suite of tests that check the tool's behavior in a flexible and robust way.
This Help Wanted issue covers the addition of unit tests to the RemoveChannelUsersCmd command, in the commands/channel.go file. The expected way to add these tests is to create a test function in the commands/channel_test.go file and add one s.Run block for each possible test case.
For more information on how to add a unit test to mmctl, take a look at the campaign blogpost: https://developers.mattermost.com/blog/unit-testing-mmctl-commands/
Example: mattermost/mmctl#37
If you have questions about the ticket or you need any help, feel free to post your question in the community CLI channel or contact miguel.delacruz in https://community.mattermost.com/.
If you're interested please comment here and come join our "Contributors" community channel on our daily build server, where you can discuss questions with community members and the Mattermost core team. For technical advice or questions, please join our "Developers" community channel.
New contributors please see our Developer's Guide.
@mgdelacroix can I work on this
I can take this one @jasonblais @hanzei
@phillipahereza, heads up that @fedealconada has expressed an interest to help with this one, so I've assigned the ticket his way. If you're still making progress on this one, feel free to ping @fedealconada and coordinate on that front. No worries if you'd prefer to pass :)
Reopening as the server PR is open: https://github.com/mattermost/mattermost-server/pull/14178
Most helpful comment
@phillipahereza, heads up that @fedealconada has expressed an interest to help with this one, so I've assigned the ticket his way. If you're still making progress on this one, feel free to ping @fedealconada and coordinate on that front. No worries if you'd prefer to pass :)